Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Side by Side Diff: src/objects.h

Issue 2388303008: [wasm] Remove dangerous ByteArray::data accessor. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 4708 matching lines...) Expand 10 before | Expand all | Expand 10 after
4719 4719
4720 // ByteArray represents fixed sized byte arrays. Used for the relocation info 4720 // ByteArray represents fixed sized byte arrays. Used for the relocation info
4721 // that is attached to code objects. 4721 // that is attached to code objects.
4722 class ByteArray: public FixedArrayBase { 4722 class ByteArray: public FixedArrayBase {
4723 public: 4723 public:
4724 inline int Size(); 4724 inline int Size();
4725 4725
4726 // Setter and getter. 4726 // Setter and getter.
4727 inline byte get(int index); 4727 inline byte get(int index);
4728 inline void set(int index, byte value); 4728 inline void set(int index, byte value);
4729 inline const byte* data() const;
4730 4729
4731 // Copy in / copy out whole byte slices. 4730 // Copy in / copy out whole byte slices.
4732 inline void copy_out(int index, byte* buffer, int length); 4731 inline void copy_out(int index, byte* buffer, int length);
4733 inline void copy_in(int index, const byte* buffer, int length); 4732 inline void copy_in(int index, const byte* buffer, int length);
4734 4733
4735 // Treat contents as an int array. 4734 // Treat contents as an int array.
4736 inline int get_int(int index); 4735 inline int get_int(int index);
4737 inline void set_int(int index, int value); 4736 inline void set_int(int index, int value);
4738 4737
4739 static int SizeFor(int length) { 4738 static int SizeFor(int length) {
(...skipping 6666 matching lines...) Expand 10 before | Expand all | Expand 10 after
11406 } 11405 }
11407 return value; 11406 return value;
11408 } 11407 }
11409 }; 11408 };
11410 11409
11411 11410
11412 } // NOLINT, false-positive due to second-order macros. 11411 } // NOLINT, false-positive due to second-order macros.
11413 } // NOLINT, false-positive due to second-order macros. 11412 } // NOLINT, false-positive due to second-order macros.
11414 11413
11415 #endif // V8_OBJECTS_H_ 11414 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698