Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2388303008: [wasm] Remove dangerous ByteArray::data accessor. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, Mircea Trofin
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove dangerous ByteArray::data accessor. R=titzer@chromium.org Committed: https://crrev.com/d874e0dca76d82603610bf6bf3378fea4abb84a3 Cr-Commit-Position: refs/heads/master@{#40028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-06 09:29:50 UTC) #1
titzer
On 2016/10/06 09:29:50, Michael Starzinger wrote: lgtm
4 years, 2 months ago (2016-10-06 09:32:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388303008/1
4 years, 2 months ago (2016-10-06 10:53:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 10:55:22 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 10:55:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d874e0dca76d82603610bf6bf3378fea4abb84a3
Cr-Commit-Position: refs/heads/master@{#40028}

Powered by Google App Engine
This is Rietveld 408576698