Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2388303007: [Offline Pages] Adds UMA for result of attempts to immediately start background loading. (Closed)
Patch Set: Merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index 830d605e57819174e291103bb0f83ca8b3704ba9..5cb9f06d84ad639f5ecd730e8f4efdfd5a9fb040 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -166,6 +166,17 @@ class RequestCoordinator : public KeyedService,
}
private:
+ enum class OfflinerImmediateStartStatus {
Mark P 2016/10/06 18:54:41 Please follow the advice here about enum histogram
dougarnett 2016/10/06 23:05:00 switched to unscoped enum with explicit values
+ STARTED,
+ BUSY,
+ NOT_ACCEPTED,
+ NO_CONNECTION,
+ NO_EFFECTIVE_CONNECTION,
Mark P 2016/10/06 18:54:41 What's the difference between this one and the one
dougarnett 2016/10/06 23:05:00 Done.
+ NOT_STARTED_ON_SVELTE,
+ // NOTE: insert new values above this line and update histogram enum too.
+ STATUS_COUNT,
+ };
+
// Receives the results of a get from the request queue, and turns that into
// SavePageRequest objects for the caller of GetQueuedRequests.
void GetQueuedRequestsCallback(
@@ -205,6 +216,8 @@ class RequestCoordinator : public KeyedService,
// as to other device conditions).
void StartProcessingIfConnected();
+ OfflinerImmediateStartStatus TryImmediateStart();
+
// Check the request queue, and schedule a task corresponding
// to the least restrictive type of request in the queue.
void ScheduleAsNeeded();

Powered by Google App Engine
This is Rietveld 408576698