[Offline Pages] Adds UMA for result of attempts to immediately start background loading.

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 353 matching lines @@
 
   is_stopped_ = false;
   scheduler_callback_ = callback;
 
   TryNextRequest();
 
   return true;
 }
 
 void RequestCoordinator::StartProcessingIfConnected() {
+  OfflinerImmediateStartStatus immediate_start_status = TryImmediateStart();
+  UMA_HISTOGRAM_ENUMERATION(
+      "OfflinePages.Background.ImmediateStartStatus",
+      static_cast<int>(immediate_start_status),

[Mark P, 2016/10/06 18:54:41]

Do you need static_casts here?  I've never seen anyone else need them.

[dougarnett, 2016/10/06 23:05:00]

Needed for scoped enums ("enum class"). Switched to unscoped enum instead.

+      static_cast<int>(
+          RequestCoordinator::OfflinerImmediateStartStatus::STATUS_COUNT));
+}
+
+RequestCoordinator::OfflinerImmediateStartStatus
+RequestCoordinator::TryImmediateStart() {
   // Make sure not already busy processing.
-  if (is_busy_) return;
+  if (is_busy_)
+    return OfflinerImmediateStartStatus::BUSY;
 
   // Make sure we are not on svelte device to start immediately.
-  if (base::SysInfo::IsLowEndDevice()) return;
+  if (base::SysInfo::IsLowEndDevice())
+    return OfflinerImmediateStartStatus::NOT_STARTED_ON_SVELTE;
 
   // Make sure we have reasonable network quality (or at least a connection).
   if (network_quality_estimator_) {
     // TODO(dougarnett): Add UMA for quality type experienced.
     net::EffectiveConnectionType quality =
         network_quality_estimator_->GetEffectiveConnectionType();
-    if (quality < net::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_2G) {
-      return;
-    }
+    if (quality < net::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_2G)
+      return OfflinerImmediateStartStatus::NO_EFFECTIVE_CONNECTION;
   } else if (GetConnectionType() ==
              net::NetworkChangeNotifier::ConnectionType::CONNECTION_NONE) {
-    return;
+    return OfflinerImmediateStartStatus::NO_CONNECTION;
   }
 
   // Start processing with manufactured conservative battery conditions
   // (i.e., assume no battery).
   // TODO(dougarnett): Obtain actual battery conditions (from Android/Java).
   DeviceConditions device_conditions(false, 0, GetConnectionType());
-  StartProcessing(device_conditions, base::Bind(&EmptySchedulerCallback));
+  if (StartProcessing(device_conditions, base::Bind(&EmptySchedulerCallback)))
+    return OfflinerImmediateStartStatus::STARTED;
+  else
+    return OfflinerImmediateStartStatus::NOT_ACCEPTED;
 }
 
 void RequestCoordinator::TryNextRequest() {
   // If there is no time left in the budget, return to the scheduler.
   // We do not remove the pending task that was set up earlier in case
   // we run out of time, so the background scheduler will return to us
   // at the next opportunity to run background tasks.
   if (base::Time::Now() - operation_start_time_ >
       base::TimeDelta::FromSeconds(
           policy_->GetBackgroundProcessingTimeBudgetSeconds())) {
@@ skipping 191 matching lines @@
   if (!offliner_) {
     offliner_ = factory_->GetOffliner(policy_.get());
   }
 }
 
 void RequestCoordinator::Shutdown() {
   network_quality_estimator_ = nullptr;
 }
 
 }  // namespace offline_pages