Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2388303006: Reland of "[turbofan] Osr value typing + dynamic type checks on entry. (patchset #5 id:80001 of htt… (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[turbofan] Osr value typing + dynamic type checks on entry. (patchset #5 id:80001 of https://codereview.chromium.org/2384113002/ )" Fixes: - Remove OsrGuards on frame specialization (for asm.js). - Handle the rename in the walk for native context. - Fix LoadContext effect wiring for Osr context chains. Committed: https://crrev.com/5d6b514192fc705bad60552903a1ce9e55c3adaa Cr-Commit-Position: refs/heads/master@{#40021}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -610 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 2 chunks +35 lines, -11 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 3 chunks +32 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-frame-specialization.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/compiler/js-frame-specialization.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/node-properties.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/osr.cc View 1 2 4 chunks +49 lines, -5 lines 0 comments Download
M src/compiler/pipeline.cc View 1 5 chunks +31 lines, -5 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +30 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/compiler/test-osr.cc View 1 chunk +0 lines, -575 lines 0 comments Download
A test/mjsunit/compiler/osr-typing-debug-change.js View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Another attempt, please?
4 years, 2 months ago (2016-10-05 12:22:59 UTC) #7
Benedikt Meurer
Another LGTM (although this is still sort of scary, as discussed offline...)
4 years, 2 months ago (2016-10-05 16:32:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388303006/40001
4 years, 2 months ago (2016-10-06 06:39:20 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 06:42:20 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:42:41 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d6b514192fc705bad60552903a1ce9e55c3adaa
Cr-Commit-Position: refs/heads/master@{#40021}

Powered by Google App Engine
This is Rietveld 408576698