Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2388303005: gzip compress more chrome:// pages (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, shishir+watch_chromium.org, dominickn+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gzip compress more chrome:// pages Specifically: - chrome://bluetooth-internals - chrome://invalidations - chrome://offline-internals - chrome://predictors - chrome://profiler - chrome://usb-internals - chrome://site-engagement This shrinks ChromePublic.apk by 58kb. BUG=619091 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/00508fbc7b679b71cb87a62a20efd4c0977f530b Cr-Commit-Position: refs/heads/master@{#423173}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M chrome/browser/browser_resources.grd View 1 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/resources/invalidations_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/invalidations_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/offline/offline_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/usb_internals/usb_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
agrieve
Not a huge win, but I'd like to ensure when people copy & paste to ...
4 years, 2 months ago (2016-10-05 02:38:18 UTC) #3
Dan Beam
lgtm you should try all these pages after your change, potentially with chrome://net-internals (and verify ...
4 years, 2 months ago (2016-10-05 03:44:45 UTC) #8
agrieve
On 2016/10/05 03:44:45, Dan Beam wrote: > lgtm > > you should try all these ...
4 years, 2 months ago (2016-10-05 14:46:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388303005/20001
4 years, 2 months ago (2016-10-05 14:46:35 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 15:58:52 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 16:00:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00508fbc7b679b71cb87a62a20efd4c0977f530b
Cr-Commit-Position: refs/heads/master@{#423173}

Powered by Google App Engine
This is Rietveld 408576698