Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2388303003: DevTools: hide new navigator interface behind experiment (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: hide new navigator interface behind experiment This patch hides the new navigator design behind the experiment. BUG=none R=pfeldman, dgozman Committed: https://crrev.com/e3009ff5c4b4c9fcd055b47ef6c539ee5c0b9546 Cr-Commit-Position: refs/heads/master@{#422872}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 6 chunks +37 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lushnikov
please, take a look for the reference: the patch which introduced a new interface instead ...
4 years, 2 months ago (2016-10-04 17:06:23 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-04 18:42:55 UTC) #4
dgozman
lgtm lgtm
4 years, 2 months ago (2016-10-04 18:42:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388303003/20001
4 years, 2 months ago (2016-10-04 18:47:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 18:53:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:59:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3009ff5c4b4c9fcd055b47ef6c539ee5c0b9546
Cr-Commit-Position: refs/heads/master@{#422872}

Powered by Google App Engine
This is Rietveld 408576698