Issue 23883007: Handlify JSObject::AddProperty method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23883007: Handlify JSObject::AddProperty method. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify JSObject::AddProperty method. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16647

Patch Set 2 : Addressed comments by Toon Verwaest. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -165 lines)			Patch
M	src/objects.h	View	1	5 chunks	+64 lines, -43 lines	0 comments	Download
M	src/objects.cc	View	1	13 chunks	+157 lines, -116 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://codereview.chromium.org/23883007/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23883007/diff/1/src/objects.cc#newcode2169 src/objects.cc:2169: MAY_BE_STORE_FROM_KEYED, PERFORM_EXTENSIBILITY_CHECK, Those 4 uppercase arguments ...

7 years, 3 months ago (2013-09-11 09:31:28 UTC) #2

Michael Starzinger

Thanks for the review. Addressed comments. Landing. https://codereview.chromium.org/23883007/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23883007/diff/1/src/objects.cc#newcode2169 src/objects.cc:2169: MAY_BE_STORE_FROM_KEYED, PERFORM_EXTENSIBILITY_CHECK, ...

7 years, 3 months ago (2013-09-11 10:52:32 UTC) #3

Michael Starzinger

7 years, 3 months ago (2013-09-11 11:00:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16647 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23883007: Handlify JSObject::AddProperty method. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Toon Verwaest. #

Messages