Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3964)

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job.h

Issue 2388253002: Use the previews black list for offline previews (Closed)
Patch Set: mmenke comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_request_job.h
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job.h b/chrome/browser/android/offline_pages/offline_page_request_job.h
index 09af8b64d90d95c94c85e0ae499ca4bbe21f59f5..c02d5a608663348fa5cbb59efc0259ffb5656eae 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job.h
+++ b/chrome/browser/android/offline_pages/offline_page_request_job.h
@@ -7,20 +7,24 @@
#include "base/memory/weak_ptr.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/common/resource_type.h"
#include "net/url_request/url_request_file_job.h"
namespace base {
class FilePath;
}
+namespace previews {
+class PreviewsDecider;
+}
+
namespace offline_pages {
// A request job that serves content from offline file.
class OfflinePageRequestJob : public net::URLRequestFileJob {
public:
// This enum is used for UMA reporting. It contains all possible outcomes of
// handling requests that might service offline page in different network
// conditions. Generally one of these outcomes will happen.
// The fringe errors (like no OfflinePageModel, etc.) are not reported due
// to their low probability.
@@ -56,43 +60,50 @@ class OfflinePageRequestJob : public net::URLRequestFileJob {
GetWebContentsGetter(net::URLRequest* request) const = 0;
virtual TabIdGetter GetTabIdGetter() const = 0;
};
// Reports the aggregated result combining both request result and network
// state.
static void ReportAggregatedRequestResult(AggregatedRequestResult result);
// Creates and returns a job to serve the offline page. Nullptr is returned if
- // offline page cannot or should not be served.
- static OfflinePageRequestJob* Create(net::URLRequest* request,
- net::NetworkDelegate* network_delegate);
+ // offline page cannot or should not be served. Embedder must gaurantee that
+ // |previews_decider| outlives the returned instance.
+ static OfflinePageRequestJob* Create(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ previews::PreviewsDecider* previews_decider);
~OfflinePageRequestJob() override;
// net::URLRequestJob overrides:
void Start() override;
void Kill() override;
void OnOfflineFilePathAvailable(const base::FilePath& offline_file_path);
void SetDelegateForTesting(std::unique_ptr<Delegate> delegate);
private:
OfflinePageRequestJob(net::URLRequest* request,
- net::NetworkDelegate* network_delegate);
+ net::NetworkDelegate* network_delegate,
+ previews::PreviewsDecider* previews_decider);
void StartAsync();
// Restarts the request job in order to fall back to the default handling.
void FallbackToDefault();
std::unique_ptr<Delegate> delegate_;
+ // Used to determine if an URLRequest is eligible for offline previews.
+ previews::PreviewsDecider* previews_decider_;
+
base::WeakPtrFactory<OfflinePageRequestJob> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(OfflinePageRequestJob);
};
} // namespace offline_pages
#endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_

Powered by Google App Engine
This is Rietveld 408576698