Use the previews black list for offline previews

chrome/browser/android/offline_pages/offline_page_request_job.h

Index: chrome/browser/android/offline_pages/offline_page_request_job.h
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job.h b/chrome/browser/android/offline_pages/offline_page_request_job.h
index 09af8b64d90d95c94c85e0ae499ca4bbe21f59f5..56b82b672564aa3c664164acc1c7f78f4c93ebd6 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job.h
+++ b/chrome/browser/android/offline_pages/offline_page_request_job.h
@@ -7,20 +7,24 @@
 
 #include "base/memory/weak_ptr.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/common/resource_type.h"
 #include "net/url_request/url_request_file_job.h"
 
 namespace base {
 class FilePath;
 }
 
+namespace previews {
+class PreviewsBlackList;
+}
+
 namespace offline_pages {
 
 // A request job that serves content from offline file.
 class OfflinePageRequestJob : public net::URLRequestFileJob {
  public:
   // This enum is used for UMA reporting. It contains all possible outcomes of
   // handling requests that might service offline page in different network
   // conditions. Generally one of these outcomes will happen.
   // The fringe errors (like no OfflinePageModel, etc.) are not reported due
   // to their low probability.
@@ -57,42 +61,48 @@ class OfflinePageRequestJob : public net::URLRequestFileJob {
 
     virtual TabIdGetter GetTabIdGetter() const = 0;
   };
 
   // Reports the aggregated result combining both request result and network
   // state.
   static void ReportAggregatedRequestResult(AggregatedRequestResult result);
 
   // Creates and returns a job to serve the offline page. Nullptr is returned if
   // offline page cannot or should not be served.
-  static OfflinePageRequestJob* Create(net::URLRequest* request,
-                                       net::NetworkDelegate* network_delegate);
+  static OfflinePageRequestJob* Create(
+      net::URLRequest* request,
+      net::NetworkDelegate* network_delegate,
+      previews::PreviewsBlackList* previews_black_list);
 
   ~OfflinePageRequestJob() override;
 
   // net::URLRequestJob overrides:
   void Start() override;
   void Kill() override;
 
   void OnOfflineFilePathAvailable(const base::FilePath& offline_file_path);
 
   void SetDelegateForTesting(std::unique_ptr<Delegate> delegate);
 
  private:
   OfflinePageRequestJob(net::URLRequest* request,
-                        net::NetworkDelegate* network_delegate);
+                        net::NetworkDelegate* network_delegate,
+                        previews::PreviewsBlackList* previews_black_list);
 
   void StartAsync();
 
   // Restarts the request job in order to fall back to the default handling.
   void FallbackToDefault();
 
   std::unique_ptr<Delegate> delegate_;
 
+  // Used to determine if an URLRequest is eligible for offline previews.

[tbansal1, 2016/10/04 12:38:04]

Comment on the lifetime: e.g., is it possible that |previews_black_list_|
changes to null during the lifetime of |this|? If yes, then this should be a
weak ptr.

[RyanSturm, 2016/10/04 21:36:38]

Done.

+  previews::PreviewsBlackList* previews_black_list_;
+
   base::WeakPtrFactory<OfflinePageRequestJob> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageRequestJob);
 };
 
 }  // namespace offline_pages
 
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_REQUEST_JOB_H_