Add test for SpdyReadQueue::Clear().

Add test for SpdyReadQueue::Clear().

* Zero out |total_size_| member in SpdyReadQueue::Clear(), otherwise the next
  call to IsEmpty() would crash.
* Add test for SpdyReadQueue::Clear().
* Add a comment to document class invariant.
* Move SpdyReadQueue tests into namespace test.

This is a follow-up to
https://crrev.com/2386883002/diff/40001/net/spdy/spdy_read_queue.cc#newcode53

Committed: https://crrev.com/5e373e7fba677f70461aeea5370f395741755e50
Cr-Commit-Position: refs/heads/master@{#422875}

[Bence, 2016-10-04 16:52:05]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 16:52:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:47:54]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-10-04 17:59:14]

bnc@chromium.org changed reviewers:
+ davidben@chromium.org

[Bence, 2016-10-04 17:59:15]

David: PTAL.  Thank you.

[davidben, 2016-10-04 18:41:49]

lgtm. Thanks!

https://codereview.chromium.org/2388243003/diff/1/net/spdy/spdy_read_queue_un...
File net/spdy/spdy_read_queue_unittest.cc (right):

https://codereview.chromium.org/2388243003/diff/1/net/spdy/spdy_read_queue_un...
net/spdy/spdy_read_queue_unittest.cc:19: namespace test {
(Huh, is that the usual pattern? I've seen unnamespaced, net::,
net::<anonymous>, but this is the first I've seen of net::test. *shrug* I'll
defer to you because I don't actually know the styles these days.)

[Bence, 2016-10-04 18:49:46]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-10-04 18:49:53]

Thank you.

https://codereview.chromium.org/2388243003/diff/1/net/spdy/spdy_read_queue_un...
File net/spdy/spdy_read_queue_unittest.cc (right):

https://codereview.chromium.org/2388243003/diff/1/net/spdy/spdy_read_queue_un...
net/spdy/spdy_read_queue_unittest.cc:19: namespace test {
On 2016/10/04 18:41:49, davidben wrote:
> (Huh, is that the usual pattern? I've seen unnamespaced, net::,
> net::<anonymous>, but this is the first I've seen of net::test. *shrug* I'll
> defer to you because I don't actually know the styles these days.)

Yes, I see this pattern quite often, see
https://cs.chromium.org/search/?q=file:%5Esrc/net.*test.cc$++%22namespace+tes....

[commit-bot: I haz the power, 2016-10-04 18:50:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:57:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 18:59:48]

Description was changed from

==========
Add test for SpdyReadQueue::Clear().

* Zero out |total_size_| member in SpdyReadQueue::Clear(), otherwise the next
  call to IsEmpty() would crash.
* Add test for SpdyReadQueue::Clear().
* Add a comment to document class invariant.
* Move SpdyReadQueue tests into namespace test.

This is a follow-up to
https://crrev.com/2386883002/diff/40001/net/spdy/spdy_read_queue.cc#newcode53
==========

to

==========
Add test for SpdyReadQueue::Clear().

* Zero out |total_size_| member in SpdyReadQueue::Clear(), otherwise the next
  call to IsEmpty() would crash.
* Add test for SpdyReadQueue::Clear().
* Add a comment to document class invariant.
* Move SpdyReadQueue tests into namespace test.

This is a follow-up to
https://crrev.com/2386883002/diff/40001/net/spdy/spdy_read_queue.cc#newcode53

Committed: https://crrev.com/5e373e7fba677f70461aeea5370f395741755e50
Cr-Commit-Position: refs/heads/master@{#422875}
==========

[commit-bot: I haz the power, 2016-10-04 18:59:49]

Patchset 1 (id:??) landed as
https://crrev.com/5e373e7fba677f70461aeea5370f395741755e50
Cr-Commit-Position: refs/heads/master@{#422875}