Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2388223002: SRTFetcher memory histograms should not use LinearHistogram. (Closed)

Created:
4 years, 2 months ago by Joe Mason
Modified:
4 years, 2 months ago
Reviewers:
rkaplow, Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SRTFetcher memory histograms should not use LinearHistogram. BUG=651903 Committed: https://crrev.com/6a82522ca23a533cf581ecb4d8b005c4d5cdfb77 Cr-Commit-Position: refs/heads/master@{#422507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Joe Mason
PTAL. Fixes a regression in M54 caused by https://codereview.chromium.org/2278013002. Hoping to get it committed before ...
4 years, 2 months ago (2016-10-03 18:19:11 UTC) #2
Jialiu Lin
lgtm
4 years, 2 months ago (2016-10-03 18:19:58 UTC) #3
rkaplow
lgtm
4 years, 2 months ago (2016-10-03 19:20:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388223002/1
4 years, 2 months ago (2016-10-03 19:31:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 20:09:50 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:12:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a82522ca23a533cf581ecb4d8b005c4d5cdfb77
Cr-Commit-Position: refs/heads/master@{#422507}

Powered by Google App Engine
This is Rietveld 408576698