Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2388213002: [Payments] If the dialog is gone, bail out (Closed)

Created:
4 years, 2 months ago by gone
Modified:
4 years, 2 months ago
Reviewers:
sebsg
CC:
chromium-reviews, agrieve+watch_chromium.org, please use gerrit instead
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] If the dialog is gone, bail out There's a poor interaction here where the Payment Request UI goes away but the Autofill CardUnmaskBridge UI doesn't, resulting in the UI being gone after the user inputs something into the other dialog. BUG=652234 Committed: https://crrev.com/4b321f75b1e568814c230362ad87b44594ed2c25 Cr-Commit-Position: refs/heads/master@{#422483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gone
sebsg@: Rouslan's out, but this seems to be a valid way to deal with this ...
4 years, 2 months ago (2016-10-03 18:11:24 UTC) #2
sebsg
lgtm
4 years, 2 months ago (2016-10-03 18:54:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388213002/1
4 years, 2 months ago (2016-10-03 18:59:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:07:23 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:09:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b321f75b1e568814c230362ad87b44594ed2c25
Cr-Commit-Position: refs/heads/master@{#422483}

Powered by Google App Engine
This is Rietveld 408576698