Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23882013: [rAc] Persist selection of newly added cards and addresses. (Closed)

Created:
7 years, 3 months ago by Ilya Sherman
Modified:
7 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAc] Persist selection of newly added cards and addresses. BUG=285458 TEST=(see bug) R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223519

Patch Set 1 #

Patch Set 2 : Fix test compile #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Use a map for greater concision. #

Patch Set 5 : Fix test compile errors #

Patch Set 6 : Fix tests, add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -67 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 4 5 6 chunks +86 lines, -21 lines 0 comments Download
M components/autofill/core/browser/autofill_common_test.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_common_test.cc View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_merge_unittest.cc View 1 2 3 4 5 2 chunks +7 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 2 chunks +11 lines, -6 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 3 4 5 7 chunks +19 lines, -9 lines 0 comments Download
M components/autofill/core/browser/test_personal_data_manager.h View 1 2 3 4 5 1 chunk +8 lines, -3 lines 0 comments Download
M components/autofill/core/browser/test_personal_data_manager.cc View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ilya Sherman
7 years, 3 months ago (2013-09-14 06:44:30 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/23882013/diff/3001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/23882013/diff/3001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode2706 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2706: std::string guid = GetManager()->SaveImportedProfile(profile); nit: I think the ...
7 years, 3 months ago (2013-09-16 16:58:12 UTC) #2
Ilya Sherman
https://chromiumcodereview.appspot.com/23882013/diff/3001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/23882013/diff/3001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode2706 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2706: std::string guid = GetManager()->SaveImportedProfile(profile); On 2013/09/16 16:58:12, Evan Stade ...
7 years, 3 months ago (2013-09-16 20:08:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/23882013/13001
7 years, 3 months ago (2013-09-16 20:13:19 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 20:23:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/23882013/29001
7 years, 3 months ago (2013-09-16 20:24:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=77562
7 years, 3 months ago (2013-09-16 21:27:19 UTC) #7
Ilya Sherman
Evan, mind taking another look? I added a unit test, which ended up being a ...
7 years, 3 months ago (2013-09-16 23:39:13 UTC) #8
Evan Stade
still lgtm
7 years, 3 months ago (2013-09-16 23:51:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/23882013/48001
7 years, 3 months ago (2013-09-16 23:52:32 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 23:59:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/23882013/48001
7 years, 3 months ago (2013-09-17 00:04:29 UTC) #12
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 02:33:07 UTC) #13
Message was sent while issue was closed. 
Change committed as 223519

Powered by Google App Engine
This is Rietveld 408576698