Explicit initialization of aura::Env for browser shell.

ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
 #include "base/bind.h"
 #include "ui/aura/client/activation_client.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/client/stacking_client.h"
+#include "ui/aura/env.h"
 #include "ui/aura/focus_manager.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/root_window_host.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
 #include "ui/aura/window_property.h"
 #include "ui/base/hit_test.h"
 #include "ui/compositor/layer.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/display.h"
@@ skipping 237 matching lines @@
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopNativeWidgetAura, internal::NativeWidgetPrivate implementation:
 
 void DesktopNativeWidgetAura::InitNativeWidget(
     const Widget::InitParams& params) {
   ownership_ = params.ownership;
 
+  aura::Env::CreateInstance();

[Ben Goodger (Google), 2013/09/17 20:39:04]

Seems like this should only be done once per process, but there can be many
DNWAs. Can't you move this to the startup sequence?

[dnicoara, 2013/09/17 21:01:27]

I see. It probably could be moved higher, but not too sure how high we want it.
I originally wanted to have it in the test SetUp, but that didn't work for these
tests.

The tests I was trying to fix are the failing ones in:
http://build.chromium.org/p/tryserver.chromium/builders/linux_aura/builds/75958

DesktopBrowserFrameAura would be another Aura specific class where it could go,
but it looks like it would have the same issue you mentioned above.

What would you recommend?

One stack trace is:

 [] aura::Env::GetInstance()
 [] aura::Window::Init()
 [] views::DesktopNativeWidgetAura::InitNativeWidget()
 [] DesktopBrowserFrameAura::InitNativeWidget()
 [] views::Widget::Init()
 [] BrowserFrame::InitBrowserFrame()
 [] BrowserWindow::CreateBrowserWindow()
 [] Browser::Browser()
 [] StartupBrowserCreatorImpl::OpenTabsInBrowser()
 [] StartupBrowserCreatorImpl::ProcessSpecifiedURLs()
 [] StartupBrowserCreatorImpl::ProcessStartupURLs()
 [] StartupBrowserCreatorImpl::ProcessLaunchURLs()
 [] StartupBrowserCreatorImpl::Launch()
 [] StartupBrowserCreator::LaunchBrowser()
 [] StartupBrowserCreator::ProcessCmdLineImpl()
 [] ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
 [] ChromeBrowserMainParts::PreMainMessageLoopRun()
 [] content::BrowserMainLoop::PreMainMessageLoopRun()
 [] content::StartupTaskRunner::RunAllTasksNow()
 [] content::BrowserMainLoop::CreateStartupTasks()
 [] content::BrowserMainRunnerImpl::Initialize()
 [] content::BrowserMain()
 [] content::BrowserTestBase::SetUp()
 [] InProcessBrowserTest::SetUp()
 [] testing::Test::Run()
 [] testing::TestInfo::Run()
 [] testing::TestCase::Run()
 [] testing::internal::UnitTestImpl::RunAllTests()
 [] testing::UnitTest::Run()

+
   NativeWidgetAura::RegisterNativeWidgetForWindow(this, window_);
   // Animations on TYPE_WINDOW are handled by the OS. Additionally if we animate
   // these windows the size of the window gets augmented, effecting restore
   // bounds and maximized windows in bad ways.
   if (params.type == Widget::InitParams::TYPE_WINDOW &&
       !params.remove_standard_frame) {
     window_->SetProperty(aura::client::kAnimationsDisabledKey, true);
   }
   window_->SetType(GetAuraWindowTypeForWidgetType(params.type));
   window_->SetTransparent(true);
@@ skipping 664 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopNativeWidgetAura, NativeWidget implementation:
 
 ui::EventHandler* DesktopNativeWidgetAura::GetEventHandler() {
   return this;
 }
 
 }  // namespace views