Issue 23882005: Revert 221130 "Convert OneClickSigninBubbleViewTest to interacti..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23882005: Revert 221130 "Convert OneClickSigninBubbleViewTest to interacti..." (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)

Modified:
7 years, 3 months ago

Reviewers:
fdoray

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 221130 "Convert OneClickSigninBubbleViewTest to interacti..." > Convert OneClickSigninBubbleViewTest to interactive_ui_tests. > > When a blur event occured during the execution of OneClickSigninBubbleViewTest, the bubble was dismissed and some assertions failed. The test has been converted to interactive_ui_tests, which is the right executable for tests that care about focus. > > TEST=Run interactive_ui_tests:OneClickSigninBubbleViewTest.* > BUG=266972 > > Review URL: https://chromiumcodereview.appspot.com/22743002 Best guess that this broke http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/7638 TBR=fdoray@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221161

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -314 lines)			Patch
D	trunk/src/chrome/browser/ui/views/sync/one_click_signin_bubble_view_interactive_uitest.cc	View	1 chunk	+0 lines, -309 lines	0 comments	Download
A +	trunk/src/chrome/browser/ui/views/sync/one_click_signin_bubble_view_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	trunk/src/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r221161.