Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2388193003: Always enqueue live regions from background tabs (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always enqueue live regions from background tabs In the case where a very lengthy live region fires on a foreground tab, and a background live region fires, don't interrupt the first live region. Also, note that a background webView does lose focus state (even when focus goes to a new window). BUG=619280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f83fa46867174390a98971d7c3c1731fdd161641 Cr-Commit-Position: refs/heads/master@{#422609}

Patch Set 1 #

Patch Set 2 : Remove obsolete helper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -79 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 1 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 1 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 1 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 2 months ago (2016-10-03 17:54:26 UTC) #4
dmazzoni
lgtm
4 years, 2 months ago (2016-10-03 18:18:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388193003/20001
4 years, 2 months ago (2016-10-03 22:40:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 00:00:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:03:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f83fa46867174390a98971d7c3c1731fdd161641
Cr-Commit-Position: refs/heads/master@{#422609}

Powered by Google App Engine
This is Rietveld 408576698