third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp - Issue 2388193002: Reflow comments in modules/peerconnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp

Issue 2388193002: Reflow comments in modules/peerconnection. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/peerconnection/RTCStatsCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp

index c2dd05ad1c32d9dbc9b244d3752b3944d387fc55..ad09df4ca2d6860854029a64a38f9d3550933272 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp

@@ -47,7 +47,8 @@ void RTCSessionDescriptionRequestPromiseImpl::requestSucceeded(

void RTCSessionDescriptionRequestPromiseImpl::requestFailed(

const String& error) {

if (m_requester && m_requester->shouldFireDefaultCallbacks()) {

- // TODO(guidou): The error code should come from the content layer. See crbug.com/589455

+ // TODO(guidou): The error code should come from the content layer. See

+ // crbug.com/589455

m_resolver->reject(DOMException::create(OperationError, error));

} else {

// This is needed to have the resolver release its internal resources