Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 2388183003: PreParsing inner functions: Fix declaration-only variables. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParsing inner functions: Fix declaration-only variables. If an inner function only declares a variable but doesn't use it, Parser and PreParser produced different unresolved variables, and that confused the pessimistic context allocation. BUG=chromium:650969 Committed: https://crrev.com/22ff09e06a3c4e26e831be228355e93b81bd3ab1 Cr-Commit-Position: refs/heads/master@{#39947}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : minor - try jobs in previous patch #

Patch Set 4 : flag off #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -5 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopes.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 1 2 4 chunks +12 lines, -5 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M test/mjsunit/fixed-context-shapes-when-recompiling.js View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Toon Verwaest
lgtm, but keep off the flag for now.
4 years, 2 months ago (2016-10-04 09:10:04 UTC) #4
marja
Yep, as discussed offline, keeping the flag off until I've fixed the overly eager context ...
4 years, 2 months ago (2016-10-04 09:11:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388183003/60001
4 years, 2 months ago (2016-10-04 09:12:04 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-04 09:38:31 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 09:38:56 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/22ff09e06a3c4e26e831be228355e93b81bd3ab1
Cr-Commit-Position: refs/heads/master@{#39947}

Powered by Google App Engine
This is Rietveld 408576698