Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2388183002: Makes WmWindowMus restore bounds use property (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes WmWindowMus restore bounds use property It shouldn't be cached locally in WmWindowMus as there is a property for it. This is covered by tests I'm working on porting. BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/accc6b5c3bf5fb6b10c4b033389703fcd2d6100c Cr-Commit-Position: refs/heads/master@{#422488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ash/mus/bridge/wm_window_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
4 years, 2 months ago (2016-10-03 17:12:28 UTC) #1
msw
lgtm
4 years, 2 months ago (2016-10-03 17:35:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388183002/1
4 years, 2 months ago (2016-10-03 17:39:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:23:38 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:26:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/accc6b5c3bf5fb6b10c4b033389703fcd2d6100c
Cr-Commit-Position: refs/heads/master@{#422488}

Powered by Google App Engine
This is Rietveld 408576698