[Sync] Move //components/sync to the syncer namespace, take 2.

[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
TBR=brettw,skym,caitkp

Committed: https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f
Cr-Commit-Position: refs/heads/master@{#422494}

[maxbogue, 2016-10-03 17:05:06]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 17:05:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-03 17:12:28]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-10-03 17:12:32]

Pavel, could you take a quick look at
	components/sync/driver/glue/ui_model_worker_unittest.cc?

[pavely, 2016-10-03 17:18:45]

lgtm

[maxbogue, 2016-10-03 17:24:27]

maxbogue@chromium.org changed reviewers:
+ brettw@chromium.org, caitkp@chromium.org, skym@chromium.org

[maxbogue, 2016-10-03 17:24:30]

TBR original reviewers.

[maxbogue, 2016-10-03 17:25:58]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
==========

to

==========
[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
TBR=brettw,skym,caitkp
==========

[maxbogue, 2016-10-03 17:27:41]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-10-03 17:27:59]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:28:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 17:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:59:19]

Failed to apply patch for
chrome/browser/sync/test/integration/multi_client_status_change_checker.h:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/sync/test/integration/multi_client_status_change_checker.h:5
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/sync/test/integration/multi_client_status_change_checker.h' with
conflicts.
  U chrome/browser/sync/test/integration/multi_client_status_change_checker.h

Patch:      
chrome/browser/sync/test/integration/multi_client_status_change_checker.h
Index: chrome/browser/sync/test/integration/multi_client_status_change_checker.h
diff --git
a/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
b/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
index
49c7a2657adb19963b2da08b4f617c83e5b28b47..3f05e3b0323435e23fe2a42b53ba51ae9747e47e
100644
--- a/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
+++ b/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
@@ -5,6 +5,7 @@
 #ifndef
CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_H_
 #define
CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_H_
 
+#include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ -20,7 +21,7 @@ class ProfileSyncService;
 // observe many ProfileSyncServices.  This class is abstract.  Its descendants
 // are expected to provide additional functionality.
 class MultiClientStatusChangeChecker : public StatusChangeChecker,
-                                       public sync_driver::SyncServiceObserver
{
+                                       public syncer::SyncServiceObserver {
  public:
   explicit MultiClientStatusChangeChecker(
       std::vector<browser_sync::ProfileSyncService*> services);
@@ -32,7 +33,7 @@ class MultiClientStatusChangeChecker : public
StatusChangeChecker,
   // Blocks until the exit condition is satisfied or a timeout occurs.
   void Wait();
 
-  // sync_driver::SyncServiceObserver implementation.
+  // syncer::SyncServiceObserver implementation.
   void OnStateChanged() override;
 
   // StatusChangeChecker implementations and stubs.

[maxbogue, 2016-10-03 18:40:26]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-10-03 18:40:28]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2388163002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-10-03 18:41:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:48:54]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
TBR=brettw,skym,caitkp
==========

to

==========
[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
TBR=brettw,skym,caitkp
==========

[commit-bot: I haz the power, 2016-10-03 19:48:59]

Committed patchset #3 (id:20001)

[commit-bot: I haz the power, 2016-10-03 19:51:01]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
TBR=brettw,skym,caitkp
==========

to

==========
[Sync] Move //components/sync to the syncer namespace, take 2.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and
  browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
 declarations. I also fixed *some* lints, especially in headers outside of the
 component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

This CL was previously reverted due to a strange leak resulting from a
redefinition of Syncer in the ui_model_worker_unittest.cc file.

BUG=646685
TBR=brettw,skym,caitkp

Committed: https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f
Cr-Commit-Position: refs/heads/master@{#422494}
==========

[commit-bot: I haz the power, 2016-10-03 19:51:05]

Patchset 3 (id:??) landed as
https://crrev.com/7e006db685d16e752115a02d7d1db1d0f5fe9d4f
Cr-Commit-Position: refs/heads/master@{#422494}