Remove bootclasspath variable from list of testrunner script inputs.

Remove bootclasspath variable from list of testrunner script inputs.

There is only 1 instance in which the bootclasspath variable is
currently used. In this case, adding bootclasspath as an input
sometimes causes an error where GN complains that there is no
path (via public_deps) to the target that generates the input file.

Since public_deps is not supported for java_prebuilt targets, I
think the simplest thing to do is just remove this file from
list of inputs.

BUG=635913
Committed: https://crrev.com/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff
Cr-Commit-Position: refs/heads/master@{#423289}

[mikecase (-- gone --), 2016-10-05 17:51:50]

mikecase@chromium.org changed reviewers:
+ agrieve@chromium.org

[mikecase (-- gone --), 2016-10-05 17:51:50]

Basically, //third_party/errorprone:javac_java generates a jar that is being
added as an input to the generated script for running errorprone. GN complains
that there is no dependency path btw these targets. Is there a way to fix this
(other than just removing the input)? It seems to want to me add
//third_party/errorprone:javac_java as a public_dep which I can't do.


=== GN Path Between the two targets ===

mikecase@mikecase:/usr/local/google/code/chromium/src$ gn path out/Errorprone
//third_party/errorprone:chromium_errorprone__java_binary_script
//third_party/errorprone:javac_java__process_jar__copy

//third_party/errorprone:chromium_errorprone__java_binary_script --[private]-->
//third_party/errorprone:javac_java --[public]-->
//third_party/errorprone:javac_java__process_jar --[public]-->
//third_party/errorprone:javac_java__process_jar__copy


=== The Error Message ===

ERROR Input to target not generated by a dependency.
The file:
  //out/Errorprone/lib.java/third_party/errorprone/javac_java.jar
is listed as an input or source for the target:
 
//third_party/errorprone:chromium_errorprone__java_binary_script(//build/toolchain/android:arm)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
 
//third_party/errorprone:javac_java__process_jar__copy(//build/toolchain/android:arm64)

If you have generated inputs, there needs to be a dependency path between the
two targets in addition to just listing the files. For indirect dependencies,
the intermediate ones must be public_deps. data_deps don't count since they're
only runtime dependencies. If you think a dependency chain exists, it might be
because the chain is private. Try "gn path" to analyze.

[agrieve, 2016-10-05 19:26:51]

I'm happy to just delete the input. It's not actually a real input anyways (you
don't need to build it in order to properly write the wrapper script).
lgtm

[mikecase (-- gone --), 2016-10-05 20:04:40]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:05:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 21:08:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 21:11:27]

Description was changed from

==========
Remove bootclasspath variable from list of testrunner script inputs.

There is only 1 instance in which the bootclasspath variable is
currently used. In this case, adding bootclasspath as an input
sometimes causes an error where GN complains that there is no
path (via public_deps) to the target that generates the input file.

Since public_deps is not supported for java_prebuilt targets, I
think the simplest thing to do is just remove this file from
list of inputs.

BUG=635913
==========

to

==========
Remove bootclasspath variable from list of testrunner script inputs.

There is only 1 instance in which the bootclasspath variable is
currently used. In this case, adding bootclasspath as an input
sometimes causes an error where GN complains that there is no
path (via public_deps) to the target that generates the input file.

Since public_deps is not supported for java_prebuilt targets, I
think the simplest thing to do is just remove this file from
list of inputs.

BUG=635913

Committed: https://crrev.com/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff
Cr-Commit-Position: refs/heads/master@{#423289}
==========

[commit-bot: I haz the power, 2016-10-05 21:11:28]

Patchset 1 (id:??) landed as
https://crrev.com/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff
Cr-Commit-Position: refs/heads/master@{#423289}