Issue 2388153005: Record a QUIC packet as received once it's been decrypted, instead of waiting for it to be fully pr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2388153005: Record a QUIC packet as received once it's been decrypted, instead of waiting for it to be fully pr… (Closed)

Created:
4 years, 2 months ago by rjshade

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Record a QUIC packet as received once it's been decrypted, instead of waiting for it to be fully processed. Protected by FLAGS_quic_receive_packet_once_decrypted. Processes stop waiting frames immediately, so it no longer uses last_stop_waiting_frame_ in QuicConnection. Merge internal change: 134893437 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -23 lines)			Patch
M	net/quic/core/quic_connection.h	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	net/quic/core/quic_connection.cc	View	6 chunks	+54 lines, -22 lines	0 comments	Download
M	net/quic/core/quic_connection_test.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_received_packet_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2399543002 Patch 1

Dependent Patchsets:

Issue 2389243004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 2 months ago (2016-10-06 02:16:18 UTC) #2

lgtm

https://codereview.chromium.org/2388153005/diff/1/net/quic/core/quic_connecti...
File net/quic/core/quic_connection.h (right):

https://codereview.chromium.org/2388153005/diff/1/net/quic/core/quic_connecti...
net/quic/core/quic_connection.h:913: //
gfe2_reloadable_flag_quic_receive_packet_once_decrypted is deprecated.
nit: can you fix the flag name (in the final CL is fine)

Expand Messages | Collapse Messages