Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2388153003: [modules] Implement namespace imports. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Implement namespace imports. This implements namespace imports (import * as foo from "bar"), except for the @@iterator property on namespace objects (to be done later). R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/57ba0ae10eef8a21845c15f4a220e97043c8a933 Cr-Commit-Position: refs/heads/master@{#40096}

Patch Set 1 #

Patch Set 2 : Fix verifier. #

Total comments: 36

Patch Set 3 : Address feedback. #

Patch Set 4 : Extend a test. #

Total comments: 2

Patch Set 5 : Fix a bug (need to do hole check in GetExport). #

Patch Set 6 : Add comment on VisitModuleNamespaceImports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -13 lines) Patch
M src/accessors.h View 3 chunks +10 lines, -2 lines 0 comments Download
M src/accessors.cc View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
M src/ast/ast-types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/compiler/types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 4 5 2 chunks +21 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 11 chunks +48 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 chunks +183 lines, -1 line 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-debug.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/modules-namespace1.js View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A test/mjsunit/modules-namespace2.js View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A test/mjsunit/modules-namespace3.js View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/modules-namespace4.js View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
M test/mjsunit/modules-skip-2.js View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/modules-skip-namespace.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
neis
4 years, 2 months ago (2016-10-04 13:47:19 UTC) #1
adamk
I'd like someone more familiar with accessors.cc (Toon?) to review that part. https://codereview.chromium.org/2388153003/diff/20001/include/v8.h File include/v8.h ...
4 years, 2 months ago (2016-10-04 18:26:53 UTC) #3
neis
https://codereview.chromium.org/2388153003/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2388153003/diff/20001/include/v8.h#newcode3543 include/v8.h:3543: * `Reflect.get`, `Function.prototype.call`, or similar functions, it is the ...
4 years, 2 months ago (2016-10-05 08:18:42 UTC) #4
neis
+mstarzinger for heap, compiler, interpreter. Thanks
4 years, 2 months ago (2016-10-05 08:37:49 UTC) #9
Michael Starzinger
LGTM on "compiler", "heap" and "interpreter". Didn't look at the rest. https://codereview.chromium.org/2388153003/diff/60001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): ...
4 years, 2 months ago (2016-10-05 13:07:30 UTC) #10
adamk
lgtm https://codereview.chromium.org/2388153003/diff/20001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/2388153003/diff/20001/src/objects.h#newcode7916 src/objects.h:7916: Object* Get(Handle<String> name); On 2016/10/05 08:18:41, neis wrote: ...
4 years, 2 months ago (2016-10-05 17:21:54 UTC) #11
neis
Adam, please have another look. I realized that we need to check for holes in ...
4 years, 2 months ago (2016-10-06 08:56:44 UTC) #14
neis
+ulan: Since Toon is OOO, would you mind having a look at accessors? Thanks.
4 years, 2 months ago (2016-10-06 13:10:44 UTC) #18
adamk
Hole checks lgtm, thanks
4 years, 2 months ago (2016-10-06 18:20:06 UTC) #19
adamk
Given the difficulty in getting an accessors reviewer and the still-early nature of this code ...
4 years, 2 months ago (2016-10-07 19:07:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388153003/100001
4 years, 2 months ago (2016-10-07 19:07:45 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-07 19:37:11 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:37:39 UTC) #27
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/57ba0ae10eef8a21845c15f4a220e97043c8a933
Cr-Commit-Position: refs/heads/master@{#40096}

Powered by Google App Engine
This is Rietveld 408576698