[downloads] Document undocumented accessors in DownloadItem.

[downloads] Document undocumented accessors in DownloadItem.

BUG=none

Committed: https://crrev.com/f963ad86e451a304de82de33e386aaadbd89d460
Cr-Commit-Position: refs/heads/master@{#422809}

[asanka, 2016-10-03 15:58:03]

asanka@chromium.org changed reviewers:
+ clamy@chromium.org

[asanka, 2016-10-03 15:58:29]

clamy: Could you take a look? This is a comment-only change.

[clamy, 2016-10-04 14:21:30]

Thanks for the clean up! Lgtm with a few nits.

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
File content/public/browser/download_item.h (right):

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:162: // will satisfy base::IsValidGUID(),
and uniquely identifies the download
nit: remove comma?

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:206: // defer from GetURL() if there were
redirects. The return value from this
nit: s/defer/differ

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:214: // subsequent browser sessions.
nit: mention that it may be different from the current & original URL?

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:335: // have saved all its data but still
waiting for some other process to
nit: s/still waiting/still be waiting

[asanka, 2016-10-04 14:43:43]

The CQ bit was checked by asanka@chromium.org

[asanka, 2016-10-04 14:43:44]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2388143002/#ps20001
(title: "Fix comma use, spelling, and other issues spotted by clamy@")

[commit-bot: I haz the power, 2016-10-04 14:44:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asanka, 2016-10-04 14:44:55]

Thanks!

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
File content/public/browser/download_item.h (right):

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:162: // will satisfy base::IsValidGUID(),
and uniquely identifies the download
On 2016/10/04 at 14:21:30, clamy wrote:
> nit: remove comma?

Done

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:206: // defer from GetURL() if there were
redirects. The return value from this
On 2016/10/04 at 14:21:29, clamy wrote:
> nit: s/defer/differ
Done

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:214: // subsequent browser sessions.
On 2016/10/04 at 14:21:30, clamy wrote:
> nit: mention that it may be different from the current & original URL?

Done

https://codereview.chromium.org/2388143002/diff/1/content/public/browser/down...
content/public/browser/download_item.h:335: // have saved all its data but still
waiting for some other process to
On 2016/10/04 at 14:21:30, clamy wrote:
> nit: s/still waiting/still be waiting

Done

[commit-bot: I haz the power, 2016-10-04 15:39:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 15:43:50]

Description was changed from

==========
[downloads] Document undocumented accessors in DownloadItem.

BUG=none
==========

to

==========
[downloads] Document undocumented accessors in DownloadItem.

BUG=none

Committed: https://crrev.com/f963ad86e451a304de82de33e386aaadbd89d460
Cr-Commit-Position: refs/heads/master@{#422809}
==========

[commit-bot: I haz the power, 2016-10-04 15:43:51]

Patchset 2 (id:??) landed as
https://crrev.com/f963ad86e451a304de82de33e386aaadbd89d460
Cr-Commit-Position: refs/heads/master@{#422809}