Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: ipc/ipc_sync_channel.h

Issue 238813010: Remove SyncChannel::SendWithTimeout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_sync_channel.h
diff --git a/ipc/ipc_sync_channel.h b/ipc/ipc_sync_channel.h
index 46ac910efdc959a05d383aae7ae5b1e982612fb9..f18fcff95ddd360344080709c4e97d5c5c38db8d 100644
--- a/ipc/ipc_sync_channel.h
+++ b/ipc/ipc_sync_channel.h
@@ -30,7 +30,7 @@ class SyncMessage;
// Overview of how the sync channel works
// --------------------------------------
// When the sending thread sends a synchronous message, we create a bunch
-// of tracking info (created in SendWithTimeout, stored in the PendingSyncMsg
+// of tracking info (created in Send, stored in the PendingSyncMsg
// structure) associated with the message that we identify by the unique
// "MessageId" on the SyncMessage. Among the things we save is the
// "Deserializer" which is provided by the sync message. This object is in
@@ -83,12 +83,6 @@ class IPC_EXPORT SyncChannel : public ChannelProxy {
virtual ~SyncChannel();
virtual bool Send(Message* message) OVERRIDE;
- virtual bool SendWithTimeout(Message* message, int timeout_ms);
-
- // Whether we allow sending messages with no time-out.
- void set_sync_messages_with_no_timeout_allowed(bool value) {
- sync_messages_with_no_timeout_allowed_ = value;
- }
// Sets the dispatch group for this channel, to only allow re-entrant dispatch
// of messages to other channels in the same group.
@@ -212,8 +206,6 @@ class IPC_EXPORT SyncChannel : public ChannelProxy {
// Starts the dispatch watcher.
void StartWatching();
- bool sync_messages_with_no_timeout_allowed_;
-
// Used to signal events between the IPC and listener threads.
base::WaitableEventWatcher dispatch_watcher_;
base::WaitableEventWatcher::EventCallback dispatch_watcher_callback_;
« no previous file with comments | « no previous file | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698