Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2388093004: Explicitly show and hide accessible rings rather than using offscreen coords. (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
xiyuan, enne (OOO)
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly show and hide accessible rings rather than using offscreen coords. BUG=648214 Committed: https://crrev.com/42fd7d7967bef71ac8d1b252c988529cbe5d8fa3 Cr-Commit-Position: refs/heads/master@{#423191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc View 5 chunks +10 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dmazzoni
This is cleaner, and the interactive_ui_tests seem to pass for me locally. This should eliminate ...
4 years, 2 months ago (2016-10-04 22:29:12 UTC) #4
enne (OOO)
Thanks for cleaning this up for me. I really appreciate you going out of your ...
4 years, 2 months ago (2016-10-04 22:39:23 UTC) #5
xiyuan
lgtm
4 years, 2 months ago (2016-10-05 16:12:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388093004/1
4 years, 2 months ago (2016-10-05 16:48:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 16:55:19 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 16:57:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42fd7d7967bef71ac8d1b252c988529cbe5d8fa3
Cr-Commit-Position: refs/heads/master@{#423191}

Powered by Google App Engine
This is Rietveld 408576698