Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: components/policy/BUILD.gn

Issue 2388063003: Add a variable use_system_xcode to GN. (Closed)
Patch Set: Comments from dpranke. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/BUILD.gn
diff --git a/components/policy/BUILD.gn b/components/policy/BUILD.gn
index 580ff4386a0435a37e7683b167ee0a5d58654d73..9a23038433e237a6a33d9b2b7f7eeaebfb063551 100644
--- a/components/policy/BUILD.gn
+++ b/components/policy/BUILD.gn
@@ -4,6 +4,7 @@
import("//build/config/chrome_build.gni")
import("//build/config/features.gni")
+import("//build/toolchain/toolchain.gni")
import("//components/policy/resources/policy_templates.gni")
import("//third_party/protobuf/proto_library.gni")
import("//tools/grit/grit_rule.gni")
@@ -220,12 +221,20 @@ if (enable_configuration_policy) {
"$target_gen_dir/$chrome_mac_bundle_id.manifest",
]
- args = [
- "plutil",
- "-convert",
- "xml1",
- ] + rebase_path(sources, root_out_dir) + [ "-o" ] +
- rebase_path(outputs, root_out_dir)
+ if (use_system_xcode) {
+ args = []
+ } else {
+ args = [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
+ args += [
+ "plutil",
+ "-convert",
+ "xml1",
+ ] + rebase_path(sources, root_out_dir) + [ "-o" ] +
+ rebase_path(outputs, root_out_dir)
deps = [
":policy_templates",

Powered by Google App Engine
This is Rietveld 408576698