Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: chrome/BUILD.gn

Issue 2388063003: Add a variable use_system_xcode to GN. (Closed)
Patch Set: Comments from dpranke. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 5739a988769360c54fc56cd29d330277a989f2ff..18dffaebe0fff0ecd55f122b9bb4c6c46ea834eb 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -11,6 +11,7 @@ import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//build/config/win/console_app.gni")
import("//build/config/win/manifest.gni")
+import("//build/toolchain/toolchain.gni")
import("//chrome/chrome_paks.gni")
import("//chrome/common/features.gni")
import("//chrome/process_version_rc_template.gni")
@@ -1035,6 +1036,14 @@ if (is_win) {
args = [
"--stamp",
rebase_path(stamp_file, root_out_dir),
+ ]
+ if (!use_system_xcode) {
+ args += [
+ "--developer-dir",
+ hermetic_xcode_path,
+ ]
+ }
+ args += [
"_ChromeMain",
rebase_path(
"$root_out_dir/$chrome_framework_name.framework/$chrome_framework_name",

Powered by Google App Engine
This is Rietveld 408576698