Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2388043004: Gallery: Set the ripple size of paper-checkbox explicitly. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
Reviewers:
yamaguchi
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Set the ripple size of paper-checkbox explicitly. Due to an issue in Polymer, the ripple size doesn't seems to be calculated properly. https://github.com/Polymer/polymer/issues/4009 We can work around this issue by setting the ripple size explicitly. BUG=652190 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2c662b2126f073010eac4fa9a5eec15ea2922afd Cr-Commit-Position: refs/heads/master@{#423106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/gallery/gallery.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fukino
PTAL
4 years, 2 months ago (2016-10-04 13:15:41 UTC) #3
yamaguchi
lgtm
4 years, 2 months ago (2016-10-05 07:36:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388043004/1
4 years, 2 months ago (2016-10-05 07:39:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 08:04:14 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 08:07:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c662b2126f073010eac4fa9a5eec15ea2922afd
Cr-Commit-Position: refs/heads/master@{#423106}

Powered by Google App Engine
This is Rietveld 408576698