Issue 238803002: Removed GetDefaultIsolate{Debugger,ForLocking,StackGuard}.

Issue 238803002: Removed GetDefaultIsolate{Debugger,ForLocking,StackGuard}. (Closed)

Created:
6 years, 8 months ago by Sven Panne

Modified:
6 years, 8 months ago

Reviewers:
Benedikt Meurer, Paweł Hajdan Jr.

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed GetDefaultIsolate{Debugger,ForLocking,StackGuard}. Some first steps towards removing the default Isolate. Fixed argument order on the way, incl. temporary helpers. BUG=359977 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20747

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 3

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -109 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -3 lines	1 comment	Download
M	include/v8-debug.h	View	2 chunks	+17 lines, -16 lines	2 comments	Download
M	src/api.cc	View	4 chunks	+10 lines, -52 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug-agent.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/isolate.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/isolate.cc	View	2 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Committed patchset #2 manually as r20747 (presubmit successful).

6 years, 8 months ago (2014-04-15 07:47:42 UTC) #3

Paweł Hajdan Jr.

Drive-by. https://codereview.chromium.org/238803002/diff/20001/include/v8-debug.h File include/v8-debug.h (left): https://codereview.chromium.org/238803002/diff/20001/include/v8-debug.h#oldcode195 include/v8-debug.h:195: static void DebugBreak(Isolate* isolate = NULL); Shouldn't these ...

6 years, 8 months ago (2014-04-17 14:24:07 UTC) #4

Sven Panne

6 years, 8 months ago (2014-04-22 07:46:25 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/238803002/diff/20001/include/v8-debug.h
File include/v8-debug.h (left):

https://codereview.chromium.org/238803002/diff/20001/include/v8-debug.h#oldco...
include/v8-debug.h:195: static void DebugBreak(Isolate* isolate = NULL);
On 2014/04/17 14:24:07, Paweł Hajdan Jr. wrote:
> Shouldn't these also go through V8_DEPRECATED before backwards-incompatible
> removal of the default parameter?

In theory yes, in practice no. The current changes done by me and Jochen on the
API are more than superficial API changes, we are changing the semantics of the
API (in this case: nuke the default Isolate). Keeping the old semantics without
a default Isolate is not possible, so things are just removed.

As a general rule of thumb, we try to follow a deprecation "process", but
sometimes it's just impossible or would be too much of a burden. API stability
is a non-goal for Chrome, and it is a non-goal for V8.

Expand Messages | Collapse Messages