Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2387993002: Prune createVisibleSelectionDeprecated from Editor (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from Editor This patch also contains a drive-by removal of a redundant layout update in |executeFindString()| in EditorCommands.cpp, because the caller of this function, Editor::Command::execute, already ensures clean layout. BUG=651373 Committed: https://crrev.com/80bbe6ca56f9fd85cc87d96cc04c7d4eee84a3d2 Cr-Commit-Position: refs/heads/master@{#422374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 05:26:57 UTC) #6
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-03 05:44:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387993002/1
4 years, 2 months ago (2016-10-03 05:45:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 05:49:40 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 05:52:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80bbe6ca56f9fd85cc87d96cc04c7d4eee84a3d2
Cr-Commit-Position: refs/heads/master@{#422374}

Powered by Google App Engine
This is Rietveld 408576698