Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 238793002: globalCompositeOperation is ignored in strokeText, fillText. (Closed)

Created:
6 years, 8 months ago by zino
Modified:
6 years, 8 months ago
Reviewers:
krit, Justin Novosad
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

globalCompositeOperation is ignored in strokeText, fillText. We make sure of supporting globalCompositeOperation about strokeText, fillText. This CL is fixing some bugs of globalCompositeOperation and adding relative tests. BUG=117675, 351178 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171756

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -33 lines) Patch
A + LayoutTests/fast/canvas/canvas-composite-text-alpha.html View 9 chunks +17 lines, -21 lines 0 comments Download
A + LayoutTests/fast/canvas/canvas-composite-text-alpha-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +28 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
zino
PTAL
6 years, 8 months ago (2014-04-15 08:09:42 UTC) #1
Justin Novosad
On 2014/04/15 08:09:42, zino wrote: > PTAL lgtm
6 years, 8 months ago (2014-04-15 14:33:29 UTC) #2
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 8 months ago (2014-04-16 04:24:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/238793002/140001
6 years, 8 months ago (2014-04-16 04:25:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 04:59:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-16 04:59:41 UTC) #6
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 8 months ago (2014-04-16 06:43:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/238793002/160001
6 years, 8 months ago (2014-04-16 06:44:04 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 08:36:01 UTC) #9
Message was sent while issue was closed.
Change committed as 171756

Powered by Google App Engine
This is Rietveld 408576698