Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: third_party/WebKit/Source/wtf/AddressSanitizer.h

Issue 2387903002: clang/win: Remove FIXME now that we don't need /fallback any more. (Closed)
Patch Set: rebase once more Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/AddressSanitizer.h
diff --git a/third_party/WebKit/Source/wtf/AddressSanitizer.h b/third_party/WebKit/Source/wtf/AddressSanitizer.h
index ba08739ef79b6cf0a8468cceeb8bf955bed79180..07b993411cea94966730b297ff986cb924a372ed 100644
--- a/third_party/WebKit/Source/wtf/AddressSanitizer.h
+++ b/third_party/WebKit/Source/wtf/AddressSanitizer.h
@@ -12,9 +12,11 @@
// TODO(sof): Add SyZyASan support?
#if defined(ADDRESS_SANITIZER)
#include <sanitizer/asan_interface.h>
+#define NO_SANITIZE_ADDRESS __attribute__((no_sanitize_address))
#else
#define ASAN_POISON_MEMORY_REGION(addr, size) ((void)(addr), (void)(size))
#define ASAN_UNPOISON_MEMORY_REGION(addr, size) ((void)(addr), (void)(size))
+#define NO_SANITIZE_ADDRESS
#endif
#if defined(LEAK_SANITIZER)
@@ -26,25 +28,12 @@
#if defined(MEMORY_SANITIZER)
#include <sanitizer/msan_interface.h>
-#endif
-
-// TODO(sof): Have to handle (ADDRESS_SANITIZER && _WIN32) differently as it
-// uses both Clang (which supports the __attribute__ syntax) and CL (which
-// doesn't) as long as we use "clang-cl /fallback". This shouldn't be needed
-// when Clang handles all the code without falling back to CL.
-#if defined(ADDRESS_SANITIZER) && (!OS(WIN) || COMPILER(CLANG))
-#define NO_SANITIZE_ADDRESS __attribute__((no_sanitize_address))
-#else
-#define NO_SANITIZE_ADDRESS
-#endif
-
-#if defined(MEMORY_SANITIZER) && (!OS(WIN) || COMPILER(CLANG))
#define NO_SANITIZE_MEMORY __attribute__((no_sanitize_memory))
#else
#define NO_SANITIZE_MEMORY
#endif
-#if defined(THREAD_SANITIZER) && (!OS(WIN) || COMPILER(CLANG))
+#if defined(THREAD_SANITIZER)
#define NO_SANITIZE_THREAD __attribute__((no_sanitize_thread))
#else
#define NO_SANITIZE_THREAD
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698