Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: tweaks and docs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/Page.cpp
diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp
index abd08205db45e514c2ced9ed8c1ce2324f4f468f..b1461b5966c8a148c13dc6411de98a8c034a8389 100644
--- a/third_party/WebKit/Source/core/page/Page.cpp
+++ b/third_party/WebKit/Source/core/page/Page.cpp
@@ -460,8 +460,8 @@ void Page::didCommitLoad(LocalFrame* frame) {
// Need to reset visual viewport position here since before commit load we would update the previous history item,
// Page::didCommitLoad is called after a new history item is created in FrameLoader.
// fix for crbug.com/642279
- frameHost().visualViewport().setScrollPosition(DoublePoint(),
- ProgrammaticScroll);
+ frameHost().visualViewport().setScrollOffset(ScrollOffset(),
+ ProgrammaticScroll);
m_hostsUsingFeatures.updateMeasurementsAndClear();
UserGestureIndicator::clearProcessedUserGestureSinceLoad();
}

Powered by Google App Engine
This is Rietveld 408576698