Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
index 6b8bd1d27a4d2efdcc1de0595602daef3cf1e2ff..b2e6e095f0f9840e161dccf0f2c46bc41dcfda51 100644
--- a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
+++ b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
@@ -326,7 +326,7 @@ TEST_F(FrameThrottlingTest, UnthrottlingTriggersRepaint) {
.mainFrameImpl()
->frameView()
->layoutViewportScrollableArea()
- ->setScrollPosition(DoublePoint(0, 480), ProgrammaticScroll);
+ ->setScrollOffset(ScrollOffset(0, 480), ProgrammaticScroll);
auto displayItems = compositeFrame();
EXPECT_FALSE(displayItems.contains(SimCanvas::Rect, "green"));
@@ -365,7 +365,7 @@ TEST_F(FrameThrottlingTest, UnthrottlingTriggersRepaintInCompositedChild) {
.mainFrameImpl()
->frameView()
->layoutViewportScrollableArea()
- ->setScrollPosition(DoublePoint(0, 480), ProgrammaticScroll);
+ ->setScrollOffset(ScrollOffset(0, 480), ProgrammaticScroll);
auto displayItems = compositeFrame();
EXPECT_FALSE(displayItems.contains(SimCanvas::Rect, "green"));
@@ -399,7 +399,7 @@ TEST_F(FrameThrottlingTest, ChangeStyleInThrottledFrame) {
.mainFrameImpl()
->frameView()
->layoutViewportScrollableArea()
- ->setScrollPosition(DoublePoint(0, 480), ProgrammaticScroll);
+ ->setScrollOffset(ScrollOffset(0, 480), ProgrammaticScroll);
auto displayItems = compositeFrame();
EXPECT_FALSE(displayItems.contains(SimCanvas::Rect, "red"));
EXPECT_FALSE(displayItems.contains(SimCanvas::Rect, "green"));
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698