Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
diff --git a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
index 7af402832792fe9f9a9d0b8c581a84abd24060ad..6730a1bb8d497b016365071641ebfca12aa2d7f9 100644
--- a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
+++ b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
@@ -158,13 +158,14 @@ TEST_F(ExternalPopupMenuTest, PopupAccountsForVisualViewportOffset) {
IntRect rectInDocument = menuList->absoluteBoundingBoxRect();
webView()->setPageScaleFactor(2);
- IntPoint scrollDelta(20, 30);
+ ScrollOffset scrollDelta(20, 30);
visualViewport.move(scrollDelta);
select->showPopup();
- EXPECT_EQ(rectInDocument.x() - scrollDelta.x(), client().shownBounds().x);
- EXPECT_EQ(rectInDocument.y() - scrollDelta.y(), client().shownBounds().y);
+ EXPECT_EQ(rectInDocument.x() - scrollDelta.width(), client().shownBounds().x);
+ EXPECT_EQ(rectInDocument.y() - scrollDelta.height(),
+ client().shownBounds().y);
}
TEST_F(ExternalPopupMenuTest, DidAcceptIndex) {
« no previous file with comments | « third_party/WebKit/Source/web/DevToolsEmulator.cpp ('k') | third_party/WebKit/Source/web/FindInPageCoordinates.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698