Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h
diff --git a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h
index 65626a687d0250b49e7c2b8a1c5ab55a4b5108fa..2040a53343c77d0124fc3152475f44937eaf879c 100644
--- a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h
+++ b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h
@@ -5,7 +5,6 @@
#ifndef ProgrammaticScrollAnimator_h
#define ProgrammaticScrollAnimator_h
-#include "platform/geometry/FloatPoint.h"
#include "platform/heap/Handle.h"
#include "platform/scroll/ScrollAnimatorCompositorCoordinator.h"
#include "wtf/Allocator.h"
@@ -30,8 +29,8 @@ class ProgrammaticScrollAnimator : public ScrollAnimatorCompositorCoordinator {
virtual ~ProgrammaticScrollAnimator();
- void scrollToOffsetWithoutAnimation(const FloatPoint&);
- void animateToOffset(FloatPoint);
+ void scrollToOffsetWithoutAnimation(const ScrollOffset&);
+ void animateToOffset(const ScrollOffset&);
// ScrollAnimatorCompositorCoordinator implementation.
void resetAnimationState() override;
@@ -52,11 +51,11 @@ class ProgrammaticScrollAnimator : public ScrollAnimatorCompositorCoordinator {
private:
explicit ProgrammaticScrollAnimator(ScrollableArea*);
- void notifyPositionChanged(const DoublePoint&);
+ void notifyOffsetChanged(const ScrollOffset&);
Member<ScrollableArea> m_scrollableArea;
std::unique_ptr<CompositorScrollOffsetAnimationCurve> m_animationCurve;
- FloatPoint m_targetOffset;
+ ScrollOffset m_targetOffset;
double m_startTime;
};

Powered by Google App Engine
This is Rietveld 408576698