third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Fix README.md Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

diff --git a/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp b/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

index 4d0f7f2c775dd52f243df8a1eafba61d65e0115c..47910c1ad54de667a3421a97a92af6158a3d3f0c 100644

--- a/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

+++ b/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

@@ -394,7 +394,7 @@ void BackgroundImageGeometry::calculate(

viewportRect.setLocation(LayoutPoint());

} else {

if (FrameView* frameView = obj.view()->frameView())

- viewportRect.setLocation(frameView->scrollPosition());

+ viewportRect.setLocation(IntPoint(frameView->scrollOffsetInt()));

// Compensate the translations created by ScrollRecorders.

// TODO(trchen): Fix this for SP phase 2. crbug.com/529963.

viewportRect.moveBy(