third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Fix README.md Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h b/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

index a916d24f295a80a181f0c46948d99b18f60d45ef..acf095b8e158fb0a2150df3262d3d5c7d6fc6b3b 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h

@@ -56,7 +56,7 @@ class ViewportScrollCallback : public ScrollStateCallback {

OverscrollController*,

RootFrameViewport&);

- bool shouldScrollTopControls(const FloatSize&, ScrollGranularity) const;

+ bool shouldScrollTopControls(const ScrollOffset&, ScrollGranularity) const;

bool scrollTopControls(ScrollState&);

ScrollResult performNativeScroll(ScrollState&);