Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: third_party/WebKit/Source/core/loader/HistoryItem.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/HistoryItem.h
diff --git a/third_party/WebKit/Source/core/loader/HistoryItem.h b/third_party/WebKit/Source/core/loader/HistoryItem.h
index 6c68b3318ac2cdf99fc168ad1491028a8019ac07..cde3bbf85667b261e2e95da89a9f9d7774bb7aa7 100644
--- a/third_party/WebKit/Source/core/loader/HistoryItem.h
+++ b/third_party/WebKit/Source/core/loader/HistoryItem.h
@@ -33,6 +33,7 @@
#include "platform/geometry/FloatPoint.h"
#include "platform/geometry/IntPoint.h"
#include "platform/heap/Handle.h"
+#include "platform/scroll/ScrollTypes.h"
#include "platform/weborigin/Referrer.h"
#include "wtf/text/WTFString.h"
@@ -59,10 +60,10 @@ class CORE_EXPORT HistoryItem final
EncodedFormData* formData();
const AtomicString& formContentType() const;
- const FloatPoint& visualViewportScrollPoint() const;
- void setVisualViewportScrollPoint(const FloatPoint&);
- const IntPoint& scrollPoint() const;
- void setScrollPoint(const IntPoint&);
+ const ScrollOffset& visualViewportScrollOffset() const;
+ void setVisualViewportScrollOffset(const ScrollOffset&);
+ const ScrollOffset& scrollOffset() const;
+ void setScrollOffset(const ScrollOffset&);
float pageScaleFactor() const;
void setPageScaleFactor(float);
@@ -113,8 +114,8 @@ class CORE_EXPORT HistoryItem final
Referrer m_referrer;
String m_target;
- FloatPoint m_visualViewportScrollPoint;
- IntPoint m_scrollPoint;
+ ScrollOffset m_visualViewportScrollOffset;
+ ScrollOffset m_scrollOffset;
float m_pageScaleFactor;
Vector<String> m_documentStateVector;
Member<DocumentState> m_documentState;
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/loader/HistoryItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698