Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
index bdeec75596726d3eefd0239b1e5ad96cbc593b16..c1760c940a85a7591147cb774325a75f4d9f0372 100644
--- a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
+++ b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
@@ -141,8 +141,8 @@ TEST_F(VisualRectMappingTest, LayoutView) {
// This case involves clipping: frame height is 50, y-coordinate of result rect is 13,
// so height should be clipped to (50 - 13) == 37.
- frameDocument.view()->setScrollPosition(DoublePoint(0, 47),
- ProgrammaticScroll);
+ frameDocument.view()->setScrollOffset(ScrollOffset(0, 47),
+ ProgrammaticScroll);
LayoutRect originalRect(4, 60, 20, 80);
LayoutRect rect = originalRect;
EXPECT_TRUE(frameText->mapToVisualRectInAncestorSpace(frameContainer, rect));
@@ -208,8 +208,8 @@ TEST_F(VisualRectMappingTest, LayoutViewDisplayNone) {
// This part is copied from the LayoutView test, just to ensure that the mapped
// rect is valid before display:none is set on the iframe.
- frameDocument.view()->setScrollPosition(DoublePoint(0, 47),
- ProgrammaticScroll);
+ frameDocument.view()->setScrollOffset(ScrollOffset(0, 47),
+ ProgrammaticScroll);
LayoutRect originalRect(4, 60, 20, 80);
LayoutRect rect = originalRect;
EXPECT_TRUE(frameDiv->mapToVisualRectInAncestorSpace(frameContainer, rect));

Powered by Google App Engine
This is Rietveld 408576698