third_party/WebKit/Source/core/input/PointerEventManager.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Fix README.md Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp

diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp

index 5412a7958e67e1d03fd707b721ea9e5f6f155612..21ce995d0f67a222d0160e4a6e62a6fa861c49a5 100644

--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp

+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp

@@ -371,8 +371,7 @@ void PointerEventManager::dispatchTouchPointerEvents(

FloatPoint pagePoint = touchInfo.targetFrame->view()->rootFrameToContents(

touchInfo.point.pos());

float scaleFactor = 1.0f / touchInfo.targetFrame->pageZoomFactor();

- FloatPoint scrollPosition =

- touchInfo.targetFrame->view()->scrollPosition();

+ FloatPoint scrollPosition(touchInfo.targetFrame->view()->scrollOffset());

FloatPoint framePoint = pagePoint.scaledBy(scaleFactor);

framePoint.moveBy(scrollPosition.scaledBy(-scaleFactor));

PointerEvent* pointerEvent = m_pointerEventFactory.create(