third_party/WebKit/Source/core/frame/FrameViewTest.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Fix README.md Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp

index ae31aae7596601813fb779bb43480f88fb1a76db..69a9db1b9826ab30346321b6774b51d9c9390247 100644

--- a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp

@@ -119,8 +119,8 @@ TEST_P(FrameViewTest, HideTooltipWhenScrollPositionChanges) {

document().view()->updateAllLifecyclePhases();

EXPECT_CALL(chromeClient(), mockSetToolTip(document().frame(), String(), _));

- document().view()->layoutViewportScrollableArea()->setScrollPosition(

- DoublePoint(1, 1), UserScroll);

+ document().view()->layoutViewportScrollableArea()->setScrollOffset(

+ ScrollOffset(1, 1), UserScroll);

}

// NoOverflowInIncrementVisuallyNonEmptyPixelCount tests fail if the number of