third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/HistoryItem.h ('K') | « third_party/WebKit/Source/core/page/SpatialNavigation.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index e3518e8738b58e352b99a0b268ea11343d73fb1d..5f840a25ee5da7761d5ef38a9307bac20940deb5 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -446,9 +446,10 @@ bool ScrollingCoordinator::scrollableAreaScrollLayerDidChange(

WebLayer* containerLayer = toWebLayer(scrollableArea->layerForContainer());

if (webLayer) {

webLayer->setScrollClipLayer(containerLayer);

- DoublePoint scrollPosition(scrollableArea->scrollPositionDouble() +

- toDoubleSize(scrollableArea->scrollOrigin()));

- webLayer->setScrollPositionDouble(scrollPosition);

+ ScrollOffset scrollOffset(

+ toScrollOffset(FloatPoint(scrollableArea->scrollOrigin()) +

+ scrollableArea->scrollOffset()));

+ webLayer->setScrollOffset(scrollOffset);

webLayer->setBounds(scrollableArea->contentsSize());

bool canScrollX = scrollableArea->userInputScrollable(HorizontalScrollbar);