third_party/WebKit/Source/core/dom/TreeScope.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TreeScope.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/TreeScope.cpp

diff --git a/third_party/WebKit/Source/core/dom/TreeScope.cpp b/third_party/WebKit/Source/core/dom/TreeScope.cpp

index 9e5b5d89cf9e74d06ae9fb5347275a60f03c6ea4..23e5a10d0c43881b62778f790aa463726344db72 100644

--- a/third_party/WebKit/Source/core/dom/TreeScope.cpp

+++ b/third_party/WebKit/Source/core/dom/TreeScope.cpp

@@ -220,7 +220,7 @@ static bool pointWithScrollAndZoomIfPossible(const Document& document,

FloatPoint pointInDocument(point);

pointInDocument.scale(frame->pageZoomFactor(), frame->pageZoomFactor());

- pointInDocument.moveBy(frameView->scrollPosition());

+ pointInDocument.moveBy(FloatPoint(frameView->scrollOffset()));

bokan 2016/10/02 19:47:50 use move() instead, it takes a FloatSize

szager1 2016/10/05 07:43:36 Done.

IntPoint roundedPointInDocument = roundedIntPoint(pointInDocument);

if (!frameView->visibleContentRect().contains(roundedPointInDocument))