Use float for scroll offset.

third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/scroll/ScrollableArea.h"
 
 #include "platform/graphics/Color.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/scroll/ScrollbarTestSuite.h"
 #include "platform/scroll/ScrollbarTheme.h"
@@ skipping 18 matching lines @@
   MOCK_CONST_METHOD3(invalidateOnThumbPositionChange,
                      ScrollbarPart(const ScrollbarThemeClient&, float, float));
 };
 
 }  // namespace
 
 class ScrollableAreaTest : public ScrollbarTestSuite {};
 
 TEST_F(ScrollableAreaTest, ScrollAnimatorCurrentPositionShouldBeSync) {
   MockScrollableArea* scrollableArea =
-      MockScrollableArea::create(IntPoint(0, 100));
-  scrollableArea->setScrollPosition(IntPoint(0, 10000), CompositorScroll);
-  EXPECT_EQ(100.0, scrollableArea->scrollAnimator().currentPosition().y());
+      MockScrollableArea::create(ScrollOffset(0, 100));
+  scrollableArea->setScrollOffset(ScrollOffset(0, 10000), CompositorScroll);
+  EXPECT_EQ(100.0, scrollableArea->scrollAnimator().currentOffset().height());
 }
 
 TEST_F(ScrollableAreaTest, ScrollbarTrackAndThumbRepaint) {
   ScrollbarThemeWithMockInvalidation theme;
   MockScrollableArea* scrollableArea =
-      MockScrollableArea::create(IntPoint(0, 100));
+      MockScrollableArea::create(ScrollOffset(0, 100));
   Scrollbar* scrollbar = Scrollbar::createForTesting(
       scrollableArea, HorizontalScrollbar, RegularScrollbar, &theme);
 
   EXPECT_CALL(theme, shouldRepaintAllPartsOnInvalidation())
       .WillRepeatedly(Return(true));
   EXPECT_TRUE(scrollbar->trackNeedsRepaint());
   EXPECT_TRUE(scrollbar->thumbNeedsRepaint());
   scrollbar->setNeedsPaintInvalidation(NoPart);
   EXPECT_TRUE(scrollbar->trackNeedsRepaint());
   EXPECT_TRUE(scrollbar->thumbNeedsRepaint());
@@ skipping 18 matching lines @@
   EXPECT_FALSE(scrollbar->trackNeedsRepaint());
   EXPECT_TRUE(scrollbar->thumbNeedsRepaint());
 
   // Forced GC in order to finalize objects depending on the mock object.
   ThreadState::current()->collectAllGarbage();
 }
 
 TEST_F(ScrollableAreaTest, ScrollbarGraphicsLayerInvalidation) {
   ScrollbarTheme::setMockScrollbarsEnabled(true);
   MockScrollableArea* scrollableArea =
-      MockScrollableArea::create(IntPoint(0, 100));
+      MockScrollableArea::create(ScrollOffset(0, 100));
   FakeGraphicsLayerClient graphicsLayerClient;
   graphicsLayerClient.setIsTrackingRasterInvalidations(true);
   FakeGraphicsLayer graphicsLayer(&graphicsLayerClient);
   graphicsLayer.setDrawsContent(true);
   graphicsLayer.setSize(FloatSize(111, 222));
 
   EXPECT_CALL(*scrollableArea, layerForHorizontalScrollbar())
       .WillRepeatedly(Return(&graphicsLayer));
 
   Scrollbar* scrollbar = Scrollbar::create(scrollableArea, HorizontalScrollbar,
                                            RegularScrollbar, nullptr);
   graphicsLayer.resetTrackedRasterInvalidations();
   scrollbar->setNeedsPaintInvalidation(NoPart);
   EXPECT_TRUE(graphicsLayer.hasTrackedRasterInvalidations());
 
   // Forced GC in order to finalize objects depending on the mock object.
   ThreadState::current()->collectAllGarbage();
 }
 
 TEST_F(ScrollableAreaTest, InvalidatesNonCompositedScrollbarsWhenThumbMoves) {
   ScrollbarThemeWithMockInvalidation theme;
   MockScrollableArea* scrollableArea =
-      MockScrollableArea::create(IntPoint(100, 100));
+      MockScrollableArea::create(ScrollOffset(100, 100));
   Scrollbar* horizontalScrollbar = Scrollbar::createForTesting(
       scrollableArea, HorizontalScrollbar, RegularScrollbar, &theme);
   Scrollbar* verticalScrollbar = Scrollbar::createForTesting(
       scrollableArea, VerticalScrollbar, RegularScrollbar, &theme);
   EXPECT_CALL(*scrollableArea, horizontalScrollbar())
       .WillRepeatedly(Return(horizontalScrollbar));
   EXPECT_CALL(*scrollableArea, verticalScrollbar())
       .WillRepeatedly(Return(verticalScrollbar));
 
   // Regardless of whether the theme invalidates any parts, non-composited
   // scrollbars have to be repainted if the thumb moves.
   EXPECT_CALL(*scrollableArea, layerForHorizontalScrollbar())
       .WillRepeatedly(Return(nullptr));
   EXPECT_CALL(*scrollableArea, layerForVerticalScrollbar())
       .WillRepeatedly(Return(nullptr));
   ASSERT_FALSE(scrollableArea->hasLayerForVerticalScrollbar());
   ASSERT_FALSE(scrollableArea->hasLayerForHorizontalScrollbar());
   EXPECT_CALL(theme, shouldRepaintAllPartsOnInvalidation())
       .WillRepeatedly(Return(false));
   EXPECT_CALL(theme, invalidateOnThumbPositionChange(_, _, _))
       .WillRepeatedly(Return(NoPart));
 
   // A scroll in each direction should only invalidate one scrollbar.
-  scrollableArea->setScrollPosition(DoublePoint(0, 50), ProgrammaticScroll);
+  scrollableArea->setScrollOffset(ScrollOffset(0, 50), ProgrammaticScroll);
   EXPECT_FALSE(scrollableArea->horizontalScrollbarNeedsPaintInvalidation());
   EXPECT_TRUE(scrollableArea->verticalScrollbarNeedsPaintInvalidation());
   scrollableArea->clearNeedsPaintInvalidationForScrollControls();
-  scrollableArea->setScrollPosition(DoublePoint(50, 50), ProgrammaticScroll);
+  scrollableArea->setScrollOffset(ScrollOffset(50, 50), ProgrammaticScroll);
   EXPECT_TRUE(scrollableArea->horizontalScrollbarNeedsPaintInvalidation());
   EXPECT_FALSE(scrollableArea->verticalScrollbarNeedsPaintInvalidation());
   scrollableArea->clearNeedsPaintInvalidationForScrollControls();
 
   // Forced GC in order to finalize objects depending on the mock object.
   ThreadState::current()->collectAllGarbage();
 }
 
 TEST_F(ScrollableAreaTest, InvalidatesCompositedScrollbarsIfPartsNeedRepaint) {
   ScrollbarThemeWithMockInvalidation theme;
   MockScrollableArea* scrollableArea =
-      MockScrollableArea::create(IntPoint(100, 100));
+      MockScrollableArea::create(ScrollOffset(100, 100));
   Scrollbar* horizontalScrollbar = Scrollbar::createForTesting(
       scrollableArea, HorizontalScrollbar, RegularScrollbar, &theme);
   horizontalScrollbar->clearTrackNeedsRepaint();
   horizontalScrollbar->clearThumbNeedsRepaint();
   Scrollbar* verticalScrollbar = Scrollbar::createForTesting(
       scrollableArea, VerticalScrollbar, RegularScrollbar, &theme);
   verticalScrollbar->clearTrackNeedsRepaint();
   verticalScrollbar->clearThumbNeedsRepaint();
   EXPECT_CALL(*scrollableArea, horizontalScrollbar())
       .WillRepeatedly(Return(horizontalScrollbar));
@@ skipping 16 matching lines @@
       .WillRepeatedly(Return(&layerForVerticalScrollbar));
   ASSERT_TRUE(scrollableArea->hasLayerForHorizontalScrollbar());
   ASSERT_TRUE(scrollableArea->hasLayerForVerticalScrollbar());
   EXPECT_CALL(theme, shouldRepaintAllPartsOnInvalidation())
       .WillRepeatedly(Return(false));
 
   // First, we'll scroll horizontally, and the theme will require repainting
   // the back button (i.e. the track).
   EXPECT_CALL(theme, invalidateOnThumbPositionChange(_, _, _))
       .WillOnce(Return(BackButtonStartPart));
-  scrollableArea->setScrollPosition(DoublePoint(50, 0), ProgrammaticScroll);
+  scrollableArea->setScrollOffset(ScrollOffset(50, 0), ProgrammaticScroll);
   EXPECT_TRUE(layerForHorizontalScrollbar.hasTrackedRasterInvalidations());
   EXPECT_FALSE(layerForVerticalScrollbar.hasTrackedRasterInvalidations());
   EXPECT_TRUE(horizontalScrollbar->trackNeedsRepaint());
   EXPECT_FALSE(horizontalScrollbar->thumbNeedsRepaint());
   layerForHorizontalScrollbar.resetTrackedRasterInvalidations();
   horizontalScrollbar->clearTrackNeedsRepaint();
 
   // Next, we'll scroll vertically, but invalidate the thumb.
   EXPECT_CALL(theme, invalidateOnThumbPositionChange(_, _, _))
       .WillOnce(Return(ThumbPart));
-  scrollableArea->setScrollPosition(DoublePoint(50, 50), ProgrammaticScroll);
+  scrollableArea->setScrollOffset(ScrollOffset(50, 50), ProgrammaticScroll);
   EXPECT_FALSE(layerForHorizontalScrollbar.hasTrackedRasterInvalidations());
   EXPECT_TRUE(layerForVerticalScrollbar.hasTrackedRasterInvalidations());
   EXPECT_FALSE(verticalScrollbar->trackNeedsRepaint());
   EXPECT_TRUE(verticalScrollbar->thumbNeedsRepaint());
   layerForVerticalScrollbar.resetTrackedRasterInvalidations();
   verticalScrollbar->clearThumbNeedsRepaint();
 
   // Next we'll scroll in both, but the thumb position moving requires no
   // invalidations. Nonetheless the GraphicsLayer should be invalidated,
   // because we still need to update the underlying layer (though no
   // rasterization will be required).
   EXPECT_CALL(theme, invalidateOnThumbPositionChange(_, _, _))
       .Times(2)
       .WillRepeatedly(Return(NoPart));
-  scrollableArea->setScrollPosition(DoublePoint(70, 70), ProgrammaticScroll);
+  scrollableArea->setScrollOffset(ScrollOffset(70, 70), ProgrammaticScroll);
   EXPECT_TRUE(layerForHorizontalScrollbar.hasTrackedRasterInvalidations());
   EXPECT_TRUE(layerForVerticalScrollbar.hasTrackedRasterInvalidations());
   EXPECT_FALSE(horizontalScrollbar->trackNeedsRepaint());
   EXPECT_FALSE(horizontalScrollbar->thumbNeedsRepaint());
   EXPECT_FALSE(verticalScrollbar->trackNeedsRepaint());
   EXPECT_FALSE(verticalScrollbar->thumbNeedsRepaint());
 
   // Forced GC in order to finalize objects depending on the mock object.
   ThreadState::current()->collectAllGarbage();
 }
 
 TEST_F(ScrollableAreaTest, RecalculatesScrollbarOverlayIfBackgroundChanges) {
   MockScrollableArea* scrollableArea =
-      MockScrollableArea::create(IntPoint(0, 100));
+      MockScrollableArea::create(ScrollOffset(0, 100));
 
   EXPECT_EQ(ScrollbarOverlayStyleDefault,
             scrollableArea->getScrollbarOverlayStyle());
   scrollableArea->recalculateScrollbarOverlayStyle(Color(34, 85, 51));
   EXPECT_EQ(ScrollbarOverlayStyleLight,
             scrollableArea->getScrollbarOverlayStyle());
   scrollableArea->recalculateScrollbarOverlayStyle(Color(236, 143, 185));
   EXPECT_EQ(ScrollbarOverlayStyleDefault,
             scrollableArea->getScrollbarOverlayStyle());
 }
 
 }  // namespace blink