Use float for scroll offset.

third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "platform/geometry/TransformState.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 122 matching lines @@
   setBodyInnerHTML(
       "<div id='overflow' style='height: 100px; width: 100px; border:8px "
       "solid; padding:7px; overflow:scroll'>"
       "    <div style='height:200px; width:200px'></div>"
       "    <div id='target' style='margin:10px; border:666px; "
       "padding:666px;'></div>"
       "</div>");
 
   LayoutObject* target = getLayoutObjectByElementId("target");
   LayoutObject* overflow = getLayoutObjectByElementId("overflow");
-  toLayoutBox(overflow)->scrollToOffset(DoubleSize(32, 54));
+  toLayoutBox(overflow)->scrollToPosition(FloatPoint(32, 54));
 
   FloatPoint mappedPoint = mapLocalToAncestor(
       target, toLayoutBoxModelObject(target->parent()), FloatPoint(100, 100));
   EXPECT_EQ(FloatPoint(93, 271), mappedPoint);
   mappedPoint = mapAncestorToLocal(
       target, toLayoutBoxModelObject(target->parent()), mappedPoint);
   EXPECT_EQ(FloatPoint(100, 100), mappedPoint);
 }
 
 TEST_F(MapCoordinatesTest, TextInRelPosInline) {
@@ skipping 352 matching lines @@
 
 TEST_F(MapCoordinatesTest, FixedPosInTransform) {
   setBodyInnerHTML(
       "<style>#container { transform: translateY(100px); position: absolute; "
       "left: 0; top: 100px; }"
       ".fixed { position: fixed; top: 0; }"
       ".spacer { height: 2000px; } </style>"
       "<div id='container'><div class='fixed' id='target'></div></div>"
       "<div class='spacer'></div>");
 
-  document().view()->setScrollPosition(DoublePoint(0.0, 50),
-                                       ProgrammaticScroll);
+  document().view()->setScrollOffset(ScrollOffset(0.0, 50), ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
-  EXPECT_EQ(50, document().view()->scrollPosition().y());
+  EXPECT_EQ(50, document().view()->scrollOffsetInt().height());
 
   LayoutBox* target = toLayoutBox(getLayoutObjectByElementId("target"));
   LayoutBox* container = toLayoutBox(getLayoutObjectByElementId("container"));
   LayoutBox* body = container->parentBox();
   LayoutBox* html = body->parentBox();
   LayoutBox* view = html->parentBox();
   ASSERT_TRUE(view->isLayoutView());
 
   FloatPoint mappedPoint = mapLocalToAncestor(target, view, FloatPoint());
   EXPECT_EQ(FloatPoint(0, 100), mappedPoint);
@@ skipping 13 matching lines @@
 
 TEST_F(MapCoordinatesTest, FixedPosInContainPaint) {
   setBodyInnerHTML(
       "<style>#container { contain: paint; position: absolute; left: 0; top: "
       "100px; }"
       ".fixed { position: fixed; top: 0; }"
       ".spacer { height: 2000px; } </style>"
       "<div id='container'><div class='fixed' id='target'></div></div>"
       "<div class='spacer'></div>");
 
-  document().view()->setScrollPosition(DoublePoint(0.0, 50),
-                                       ProgrammaticScroll);
+  document().view()->setScrollOffset(ScrollOffset(0.0, 50), ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
-  EXPECT_EQ(50, document().view()->scrollPosition().y());
+  EXPECT_EQ(50, document().view()->scrollOffsetInt().height());
 
   LayoutBox* target = toLayoutBox(getLayoutObjectByElementId("target"));
   LayoutBox* container = toLayoutBox(getLayoutObjectByElementId("container"));
   LayoutBox* body = container->parentBox();
   LayoutBox* html = body->parentBox();
   LayoutBox* view = html->parentBox();
   ASSERT_TRUE(view->isLayoutView());
 
   FloatPoint mappedPoint = mapLocalToAncestor(target, view, FloatPoint());
   EXPECT_EQ(FloatPoint(0, 100), mappedPoint);
@@ skipping 19 matching lines @@
       "<div style='width: 200; height: 8000px'></div>"
       "<iframe id=frame src='http://test.com' width='500' height='500' "
       "frameBorder='0'>"
       "</iframe>");
 
   Document& frameDocument = setupChildIframe(
       "frame",
       "<style>body { margin: 0; } #target { width: 200px; height: 200px; "
       "position:fixed}</style><div id=target></div>");
 
-  document().view()->setScrollPosition(DoublePoint(0.0, 1000),
-                                       ProgrammaticScroll);
+  document().view()->setScrollOffset(ScrollOffset(0.0, 1000),
+                                     ProgrammaticScroll);
   document().view()->updateAllLifecyclePhases();
 
   Element* target = frameDocument.getElementById("target");
   ASSERT_TRUE(target);
   FloatPoint mappedPoint =
       mapAncestorToLocal(target->layoutObject(), nullptr, FloatPoint(10, 70),
                          TraverseDocumentBoundaries);
 
   // y = 70 - 8000, since the iframe is offset by 8000px from the main frame.
   // The scroll is not taken into account because the element is not fixed to the root LayoutView,
   // and the space of the root LayoutView does not include scroll.
   EXPECT_EQ(FloatPoint(10, -7930), mappedPoint);
 }
 
 TEST_F(MapCoordinatesTest, IFrameTransformed) {
   document().setBaseURLOverride(KURL(ParsedURLString, "http://test.com"));
   setBodyInnerHTML(
       "<style>body { margin: 0; }</style>"
       "<iframe style='transform: scale(2)' id=frame src='http://test.com' "
       "width='500' height='500' frameBorder='0'>"
       "</iframe>");
 
   Document& frameDocument =
       setupChildIframe("frame",
                        "<style>body { margin: 0; } #target { width: 200px; "
                        "height: 8000px}</style><div id=target></div>");
 
   document().view()->updateAllLifecyclePhases();
 
-  frameDocument.view()->setScrollPosition(DoublePoint(0.0, 1000),
-                                          ProgrammaticScroll);
+  frameDocument.view()->setScrollOffset(ScrollOffset(0.0, 1000),
+                                        ProgrammaticScroll);
   frameDocument.view()->updateAllLifecyclePhases();
 
   Element* target = frameDocument.getElementById("target");
   ASSERT_TRUE(target);
   FloatPoint mappedPoint =
       mapAncestorToLocal(target->layoutObject(), nullptr, FloatPoint(200, 200),
                          TraverseDocumentBoundaries | UseTransforms);
 
   // Derivation:
   // (200, 200) -> (-50, -50)  (Adjust for transform origin of scale, which is at the center of the 500x500 iframe)
@@ skipping 14 matching lines @@
       "height='768'></iframe>"
       "</div>");
 
   Document& frameDocument = setupChildIframe(
       "frame",
       "<style>* { margin: 0; } #target { width: 200px; height: 200px; "
       "position:fixed}</style><div id=target></div>"
       "<div style='width: 200; height: 8000px'></div>");
 
   document().view()->updateAllLifecyclePhases();
-  frameDocument.view()->setScrollPosition(DoublePoint(0.0, 1000),
-                                          ProgrammaticScroll);
+  frameDocument.view()->setScrollOffset(ScrollOffset(0.0, 1000),
+                                        ProgrammaticScroll);
 
   Element* target = frameDocument.getElementById("target");
   ASSERT_TRUE(target);
   FloatPoint mappedPoint =
       mapAncestorToLocal(target->layoutObject(), nullptr, FloatPoint(0, 0),
                          UseTransforms | TraverseDocumentBoundaries);
 
   EXPECT_EQ(FloatPoint(0, 0), mappedPoint);
 }
 
@@ skipping 770 matching lines @@
               LayoutUnit::epsilon());
   EXPECT_NEAR(50.0, matrix.projectPoint(FloatPoint(100.0, 50.0)).y(),
               LayoutUnit::epsilon());
   EXPECT_NEAR(25.0, matrix.projectPoint(FloatPoint(50.0, 100.0)).x(),
               LayoutUnit::epsilon());
   EXPECT_NEAR(100.0, matrix.projectPoint(FloatPoint(50.0, 100.0)).y(),
               LayoutUnit::epsilon());
 }
 
 }  // namespace blink