Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2016 Google Inc. All rights reserved. 2 * Copyright (C) 2016 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 17 matching lines...) Expand all
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef DOMVisualViewport_h 31 #ifndef DOMVisualViewport_h
32 #define DOMVisualViewport_h 32 #define DOMVisualViewport_h
33 33
34 #include "bindings/core/v8/ScriptWrappable.h" 34 #include "bindings/core/v8/ScriptWrappable.h"
35 #include "core/dom/ExecutionContext.h" 35 #include "core/dom/ExecutionContext.h"
36 #include "core/events/EventTarget.h" 36 #include "core/events/EventTarget.h"
37 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
38 #include "platform/scroll/ScrollTypes.h"
38 39
39 namespace blink { 40 namespace blink {
40 41
41 class LocalDOMWindow; 42 class LocalDOMWindow;
42 class ExecutionContext; 43 class ExecutionContext;
43 44
44 class DOMVisualViewport final : public EventTargetWithInlineData { 45 class DOMVisualViewport final : public EventTargetWithInlineData {
45 DEFINE_WRAPPERTYPEINFO(); 46 DEFINE_WRAPPERTYPEINFO();
46 47
47 public: 48 public:
48 static DOMVisualViewport* create(LocalDOMWindow* window) { 49 static DOMVisualViewport* create(LocalDOMWindow* window) {
49 return new DOMVisualViewport(window); 50 return new DOMVisualViewport(window);
50 } 51 }
51 52
52 ~DOMVisualViewport() override; 53 ~DOMVisualViewport() override;
53 54
54 DECLARE_VIRTUAL_TRACE(); 55 DECLARE_VIRTUAL_TRACE();
55 56
56 // EventTarget overrides: 57 // EventTarget overrides:
57 const AtomicString& interfaceName() const override; 58 const AtomicString& interfaceName() const override;
58 ExecutionContext* getExecutionContext() const override; 59 ExecutionContext* getExecutionContext() const override;
59 60
60 double scrollLeft(); 61 float scrollLeft();
61 double scrollTop(); 62 float scrollTop();
62 double pageX(); 63 float pageX();
63 double pageY(); 64 float pageY();
64 double clientWidth(); 65 double clientWidth();
65 double clientHeight(); 66 double clientHeight();
66 double scale(); 67 double scale();
67 68
68 private: 69 private:
69 explicit DOMVisualViewport(LocalDOMWindow*); 70 explicit DOMVisualViewport(LocalDOMWindow*);
70 71
71 Member<LocalDOMWindow> m_window; 72 Member<LocalDOMWindow> m_window;
72 }; 73 };
73 74
74 } // namespace blink 75 } // namespace blink
75 76
76 #endif // DOMVisualViewport_h 77 #endif // DOMVisualViewport_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698