Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 // TODO(rbyers): Most of this doesn't appear to take into account that each 453 // TODO(rbyers): Most of this doesn't appear to take into account that each
454 // SVGImage gets it's own Page instance. 454 // SVGImage gets it's own Page instance.
455 frameHost().consoleMessageStorage().clear(); 455 frameHost().consoleMessageStorage().clear();
456 useCounter().didCommitLoad(); 456 useCounter().didCommitLoad();
457 deprecation().clearSuppression(); 457 deprecation().clearSuppression();
458 frameHost().visualViewport().sendUMAMetrics(); 458 frameHost().visualViewport().sendUMAMetrics();
459 459
460 // Need to reset visual viewport position here since before commit load we w ould update the previous history item, 460 // Need to reset visual viewport position here since before commit load we w ould update the previous history item,
461 // Page::didCommitLoad is called after a new history item is created in Fram eLoader. 461 // Page::didCommitLoad is called after a new history item is created in Fram eLoader.
462 // fix for crbug.com/642279 462 // fix for crbug.com/642279
463 frameHost().visualViewport().setScrollPosition(DoublePoint(), 463 frameHost().visualViewport().setScrollOffset(ScrollOffset(),
464 ProgrammaticScroll); 464 ProgrammaticScroll);
465 m_hostsUsingFeatures.updateMeasurementsAndClear(); 465 m_hostsUsingFeatures.updateMeasurementsAndClear();
466 UserGestureIndicator::clearProcessedUserGestureSinceLoad(); 466 UserGestureIndicator::clearProcessedUserGestureSinceLoad();
467 } 467 }
468 } 468 }
469 469
470 void Page::acceptLanguagesChanged() { 470 void Page::acceptLanguagesChanged() {
471 HeapVector<Member<LocalFrame>> frames; 471 HeapVector<Member<LocalFrame>> frames;
472 472
473 // Even though we don't fire an event from here, the LocalDOMWindow's will fir e 473 // Even though we don't fire an event from here, the LocalDOMWindow's will fir e
474 // an event so we keep the frames alive until we are done. 474 // an event so we keep the frames alive until we are done.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 : chromeClient(nullptr), 537 : chromeClient(nullptr),
538 contextMenuClient(nullptr), 538 contextMenuClient(nullptr),
539 editorClient(nullptr), 539 editorClient(nullptr),
540 spellCheckerClient(nullptr) {} 540 spellCheckerClient(nullptr) {}
541 541
542 Page::PageClients::~PageClients() {} 542 Page::PageClients::~PageClients() {}
543 543
544 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 544 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
545 545
546 } // namespace blink 546 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698